Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSR import specifiers cannot be resolved #11

Closed
benStre opened this issue Apr 22, 2024 · 3 comments · Fixed by #12
Closed

JSR import specifiers cannot be resolved #11

benStre opened this issue Apr 22, 2024 · 3 comments · Fixed by #12

Comments

@benStre
Copy link

benStre commented Apr 22, 2024

In the recent release, the deno.land imports where replaced with JSR imports.
Because the imports specifiers are no longer full URLS ("@std/fmt/colors") and are resolved via the adjacent importmap (i.e. deno.json),
the charmd module can no longer be imported as https://deno.land/x/charmd/mod.ts in a deno module without this exact importmap. This is a breaking change that unfortunately breaks all our projects that include charmd.

@littletof
Copy link
Owner

Yeah, that wasn't the intention, sorry! Thanks for reporting!
I will make the fix soon.

Also, make sure to use explicit version, so at least production code does not break in the future.
But I will also try not to be a cause for such things in the future 😉

@littletof
Copy link
Owner

@benStre Just released v0.1.2
I tested it, and also added some basic CI tests to check that different distributions work, seems like it works now.

Regardless, can you please validate that this solved it on your side too?

@benStre
Copy link
Author

benStre commented Apr 24, 2024

Thank you.
It works again on our side, and we are now also using fixed versions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants