Merge pull request #41 from litecoinz-core/Lwma

Release v3.0.4

Author: MarkLTZ

configure.ac

@@ -2,11 +2,11 @@ dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
 AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 3)
 define(_CLIENT_VERSION_MINOR, 0)
-define(_CLIENT_VERSION_REVISION, 3)
+define(_CLIENT_VERSION_REVISION, 4)
 define(_CLIENT_VERSION_BUILD, 0)
 define(_CLIENT_VERSION_RC, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)
-define(_COPYRIGHT_YEAR, 2020)
+define(_COPYRIGHT_YEAR, 2024)
 define(_COPYRIGHT_HOLDERS,[The %s developers])
 define(_COPYRIGHT_HOLDERS_SUBSTITUTION,[[LitecoinZ Core]])
 AC_INIT([LitecoinZ Core],m4_join([.], _CLIENT_VERSION_MAJOR, _CLIENT_VERSION_MINOR, _CLIENT_VERSION_REVISION, m4_if(_CLIENT_VERSION_BUILD, [0], [], _CLIENT_VERSION_BUILD))m4_if(_CLIENT_VERSION_RC, [0], [], [rc]_CLIENT_VERSION_RC),[https://github.com/litecoinz-core/litecoinz/issues],[litecoinz],[https://litecoinz.org/])

doc/man/litecoinz-cli.1

@@ -1,7 +1,7 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.6.
-.TH LITECOINZ-CLI "1" "December 2020" "litecoinz-cli v3.0.3.0" "User Commands"
+.TH LITECOINZ-CLI "1" "June 2024" "litecoinz-cli v3.0.4.0" "User Commands"
 .SH NAME
-litecoinz-cli \- manual page for litecoinz-cli v3.0.3.0
+litecoinz-cli \- manual page for litecoinz-cli v3.0.4.0
 .SH SYNOPSIS
 .B litecoinz-cli
 [\fI\,options\/\fR] \fI\,<command> \/\fR[\fI\,params\/\fR]  \fI\,Send command to LitecoinZ Core\/\fR
@@ -15,7 +15,7 @@ litecoinz-cli \- manual page for litecoinz-cli v3.0.3.0
 .B litecoinz-cli
 [\fI\,options\/\fR] \fI\,help <command>      Get help for a command\/\fR
 .SH DESCRIPTION
-LitecoinZ Core RPC client version v3.0.3.0
+LitecoinZ Core RPC client version v3.0.4.0
 .SH OPTIONS
 .HP
 \-?
@@ -112,7 +112,7 @@ regtest
 Use the test chain. Equivalent to \fB\-chain\fR=\fI\,test\/\fR.
 .SH COPYRIGHT
 Copyright (C) 2009-2020 The Bitcoin Core developers
-Copyright (C) 2017-2020 The LitecoinZ Core developers
+Copyright (C) 2017-2024 The LitecoinZ Core developers
 
 Please contribute if you find LitecoinZ Core useful. Visit
 <https://litecoinz.org> for further information about the software.

doc/man/litecoinz-qt.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.6.
-.TH LITECOINZ-QT "1" "December 2020" "litecoinz-qt v3.0.3.0" "User Commands"
+.TH LITECOINZ-QT "1" "June 2024" "litecoinz-qt v3.0.4.0" "User Commands"
 .SH NAME
-litecoinz-qt \- manual page for litecoinz-qt v3.0.3.0
+litecoinz-qt \- manual page for litecoinz-qt v3.0.4.0
 .SH SYNOPSIS
 .B litecoinz-qt
 [\fI\,command-line options\/\fR]
 .SH DESCRIPTION
-LitecoinZ Core version v3.0.3.0 (64\-bit)
+LitecoinZ Core version v3.0.4.0 (64\-bit)
 .SH OPTIONS
 .HP
 \-?
@@ -653,7 +653,7 @@ Set SSL root certificates for payment request (default: \fB\-system\-\fR)
 Show splash screen on startup (default: 1)
 .SH COPYRIGHT
 Copyright (C) 2009-2020 The Bitcoin Core developers
-Copyright (C) 2017-2020 The LitecoinZ Core developers
+Copyright (C) 2017-2024 The LitecoinZ Core developers
 
 Please contribute if you find LitecoinZ Core useful. Visit
 <https://litecoinz.org> for further information about the software.

doc/man/litecoinz-tx.1

@@ -1,15 +1,15 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.6.
-.TH LITECOINZ-TX "1" "December 2020" "litecoinz-tx v3.0.3.0" "User Commands"
+.TH LITECOINZ-TX "1" "June 2024" "litecoinz-tx v3.0.4.0" "User Commands"
 .SH NAME
-litecoinz-tx \- manual page for litecoinz-tx v3.0.3.0
+litecoinz-tx \- manual page for litecoinz-tx v3.0.4.0
 .SH SYNOPSIS
 .B litecoinz-tx
 [\fI\,options\/\fR] \fI\,<hex-tx> \/\fR[\fI\,commands\/\fR]  \fI\,Update hex-encoded litecoinz transaction\/\fR
 .br
 .B litecoinz-tx
 [\fI\,options\/\fR] \fI\,-create \/\fR[\fI\,commands\/\fR]   \fI\,Create hex-encoded litecoinz transaction\/\fR
 .SH DESCRIPTION
-LitecoinZ Core litecoinz\-tx utility version v3.0.3.0
+LitecoinZ Core litecoinz\-tx utility version v3.0.4.0
 .SH OPTIONS
 .HP
 \-?
@@ -113,7 +113,7 @@ set=NAME:JSON\-STRING
 Set register NAME to given JSON\-STRING
 .SH COPYRIGHT
 Copyright (C) 2009-2020 The Bitcoin Core developers
-Copyright (C) 2017-2020 The LitecoinZ Core developers
+Copyright (C) 2017-2024 The LitecoinZ Core developers
 
 Please contribute if you find LitecoinZ Core useful. Visit
 <https://litecoinz.org> for further information about the software.

doc/man/litecoinz-wallet.1

@@ -1,9 +1,9 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.6.
-.TH LITECOINZ-WALLET "1" "December 2020" "litecoinz-wallet v3.0.3.0" "User Commands"
+.TH LITECOINZ-WALLET "1" "June 2024" "litecoinz-wallet v3.0.4.0" "User Commands"
 .SH NAME
-litecoinz-wallet \- manual page for litecoinz-wallet v3.0.3.0
+litecoinz-wallet \- manual page for litecoinz-wallet v3.0.4.0
 .SH DESCRIPTION
-LitecoinZ Core litecoinz\-wallet version v3.0.3.0
+LitecoinZ Core litecoinz\-wallet version v3.0.4.0
 .PP
 wallet\-tool is an offline tool for creating and interacting with LitecoinZ Core wallet files.
 By default wallet\-tool will act on wallets in the default mainnet wallet directory in the datadir.
@@ -58,7 +58,7 @@ info
 Get wallet info
 .SH COPYRIGHT
 Copyright (C) 2009-2020 The Bitcoin Core developers
-Copyright (C) 2017-2020 The LitecoinZ Core developers
+Copyright (C) 2017-2024 The LitecoinZ Core developers
 
 Please contribute if you find LitecoinZ Core useful. Visit
 <https://litecoinz.org> for further information about the software.

doc/man/litecoinzd.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.6.
-.TH LITECOINZD "1" "December 2020" "litecoinzd v3.0.3.0" "User Commands"
+.TH LITECOINZD "1" "June 2024" "litecoinzd v3.0.4.0" "User Commands"
 .SH NAME
-litecoinzd \- manual page for litecoinzd v3.0.3.0
+litecoinzd \- manual page for litecoinzd v3.0.4.0
 .SH SYNOPSIS
 .B litecoinzd
 [\fI\,options\/\fR]                     \fI\,Start LitecoinZ Core\/\fR
 .SH DESCRIPTION
-LitecoinZ Core version v3.0.3.0
+LitecoinZ Core version v3.0.4.0
 .SH OPTIONS
 .HP
 \-?
@@ -627,7 +627,7 @@ Username for JSON\-RPC connections
 Accept command line and JSON\-RPC commands
 .SH COPYRIGHT
 Copyright (C) 2009-2020 The Bitcoin Core developers
-Copyright (C) 2017-2020 The LitecoinZ Core developers
+Copyright (C) 2017-2024 The LitecoinZ Core developers
 
 Please contribute if you find LitecoinZ Core useful. Visit
 <https://litecoinz.org> for further information about the software.

doc/release-notes/release-notes-3.0.4.md

@@ -0,0 +1,72 @@
+3.0.4 Release Notes
+===============
+
+LitecoinZ Core version 3.0.4 is now available from:
+
+https://github.com/litecoinz-core/litecoinz/releases/tag/v3.0.4
+
+This is a new major version release, including new features, various bugfixes and performance improvements, as well as updated translations.
+
+Please report bugs using the issue tracker at GitHub:
+
+https://github.com/litecoinz-core/litecoinz/issues
+
+How to Upgrade
+===============
+
+No actions are required if you are running version v3.0.0 or later.
+
+If you are running a version older than v3.0.0, shut it down. Wait until it has completely
+shut down (which might take a few minutes for older versions), then make a
+backup of the file wallet.dat and run the installer (on Windows) or just copy
+over /Applications/LitecoinZ-Qt (on Mac) or litecoinz/litecoinz-qt (on Linux).
+
+Run the following command:
+
+```./litecoinzd -upgradewallet -rescan -reindex```
+
+or
+
+```./litecoinz-qt -upgradewallet -rescan -reindex```
+
+If running on Windows:
+
+```litecoinzd.exe -upgradewallet -rescan -reindex```
+
+or
+
+```litecoinz-qt.exe -upgradewallet -rescan -reindex```
+
+Notable changes
+===============
+
+Hard Fork at height 765949
+-----------------------------------
+Switching to the new PoW algorithm Zawy Lwma. This should reduce hash power spikes.
+
+Difficulty reset
+--------------------------
+Adjusted difficulty for resuming from a long period of inactivity.
+
+SPROUT Addresses
+--------------------------
+Creating new legacy SPROUT addresses is now disabled.
+
+Fixes:
+======
+
+- Fix z_getnewaddress issue on encrypted wallet
+- Fix gitian build
+- Fix 'z_getnewaddress' issue
+- Fix missing EXCLUSIVE_LOCKS_REQUIRED
+- Fix 'QFlags is deprecated' warnings
+- Fix 'buttonClicked is deprecated' warnings
+- Fix 'QDateTime is deprecated' warnings
+- Fix 'split is deprecated' warnings
+- Fix 'pixmap is deprecated' warnings
+- Fix bad-sapling-root-in-block issue
+
+Known issues
+===============
+
+* There is an issue on Windows with not latin characters in user profile path. To solve this issue please start LitecoinZ using parameters ```-datadir``` and ```-paramsdir``` specifying a custom folder. Example: litecoinz-qt.exe -datadir=C:\LTZ\Data -paramsdir=C:\LTZ\Params

src/chainparams.cpp

@@ -95,8 +95,12 @@ class CMainParams : public CChainParams {
         consensus.nLegacyLwmaForkHeight = 600000;
         consensus.nLegacyLwmaAveragingWindow = 60;
         consensus.nLegacyPowTargetSpacing = 10 * 60;
-        consensus.nLwmaForkHeight = std::numeric_limits<int>::max();
-        consensus.nLwmaAveragingWindow = 120;
+        consensus.nLwmaForkHeight = 765949;
+        consensus.nLwmaAveragingWindow = 45;
+        consensus.nLwmaAdjustedWeight = 3443;
+        consensus.nLwmaMinDenominator = 10;
+        consensus.fLwmaSolvetimeLimitation = true;
+
         consensus.nPowTargetSpacing = 2.5 * 60;
 
         consensus.fPowAllowMinDifficultyBlocks = false;
@@ -263,7 +267,11 @@ class CTestNetParams : public CChainParams {
         consensus.nLegacyLwmaAveragingWindow = 60;
         consensus.nLegacyPowTargetSpacing = 10 * 60;
         consensus.nLwmaForkHeight = 7000;
-        consensus.nLwmaAveragingWindow = 120;
+        consensus.nLwmaAveragingWindow = 45;
+        consensus.nLwmaAdjustedWeight = 3443;
+        consensus.nLwmaMinDenominator = 10;
+        consensus.fLwmaSolvetimeLimitation = true;
+
         consensus.nPowTargetSpacing = 2.5 * 60;
 
         consensus.fPowAllowMinDifficultyBlocks = false;
@@ -406,7 +414,11 @@ class CRegTestParams : public CChainParams {
         consensus.nLegacyLwmaAveragingWindow = 60;
         consensus.nLegacyPowTargetSpacing = 10 * 60;
         consensus.nLwmaForkHeight = -1; // Activated on regtest
-        consensus.nLwmaAveragingWindow = 120;
+        consensus.nLwmaAveragingWindow = 45;
+        consensus.nLwmaAdjustedWeight = 3443;
+        consensus.nLwmaMinDenominator = 10;
+        consensus.fLwmaSolvetimeLimitation = true;
+
         consensus.nPowTargetSpacing = 2.5 * 60;
 
         consensus.fPowAllowMinDifficultyBlocks = true;

src/consensus/params.h

@@ -195,6 +195,10 @@ struct Params {
 
     // Params for Lwma difficulty adjustment algorithm.
     int64_t nLwmaAveragingWindow;
+    int64_t nLwmaAdjustedWeight;  // k = (N+1)/2 * 0.998 * T
+    int64_t nLwmaMinDenominator;
+    bool fLwmaSolvetimeLimitation;
+
     int64_t nPowTargetSpacing;
 
     uint256 nMinimumChainWork;

src/miner.cpp

@@ -168,10 +168,11 @@ std::unique_ptr<CBlockTemplate> BlockAssembler::CreateNewBlock(const CScript& sc
     pblocktemplate->vTxFees[0] = -nFees;
 
     // Update the Sapling commitment tree.
-    for (const CTransactionRef& ptx : pblock->vtx) {
-        const CTransaction& tx = *ptx;
-        for (const OutputDescription& odesc : tx.vShieldedOutput) {
-            sapling_tree.append(odesc.cm);
+    for (unsigned int i = 0; i < pblock->vtx.size(); i++)
+    {
+        const CTransaction &tx = *(pblock->vtx[i]);
+        for (const OutputDescription &outputDescription : tx.vShieldedOutput) {
+            sapling_tree.append(outputDescription.cm);
         }
     }