[liqoctl] set gateway server Service location in peer command

[fra98]

Description

This PR introduces the support to specify the gateway client and server location in a peering.
The --server-service-location flag in liqoctl peer allows to place the gateway server service in the provider (default) or consumer.
This can be useful if you cannot expose Services (or don't have LB UDP support) in the provider cluster or if the provider is behind a NAT (without going through the manual peering procedure or setting up the networking module individually).

[adamjensenbot]

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

• /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
  when the rebase operation is completed)
• /merge: Merge this PR into the master branch
• /build Build Liqo components
• /test Launch the E2E and Unit tests
• /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

• feat: 🚀 New Feature
• fix: 🐛 Bug Fix
• refactor: 🧹 Code Refactoring
• docs: 📝 Documentation
• style: 💄 Code Style
• perf: 🐎 Performance Improvement
• test: ✅ Tests
• chore: 🚚 Dependencies Management
• build: 📦 Builds Management
• ci: 👷 CI/CD
• revert: ⏪ Reverts Previous Changes

[fra98]

/rebase

[fra98]

/test

[fra98]

/test

[fra98]

/test

[fra98]

/test

[fra98]

/test

[fra98]

/test

[fra98]

/rebase test=true

[frisso]

Difficult for me to understand what "server" means in the command line, "--server-service-location".
I would suggest to propose a more intuitive name (e.g., --gateway-server-location", perhaps?)

[fra98]

Difficult for me to understand what "server" means in the command line, "--server-service-location". I would suggest to propose a more intuitive name (e.g., --gateway-server-location", perhaps?)

Hi @frisso, the purpose of this flag is to allow the user to customize the location of the k8s Service that exposes the Gateway Server.
The rationale to keep the word service is that it's the most important thing to know for the common liqoctl peer user that does not need to know the internal of Liqo, nor what type of Server this is or what it does. For this flag, the thing that matters the most is the ability to expose a LoadBalancer Service (if not using NodePort ofc); therefore, the user should choose the cluster equipped with a working LoadBalancer provider.
Other reasons are:

• coherence with other flags that customize the k8s Service (e.g,, --server-service-port, --server-service-loadbalancerip)
• a more exhaustive name (e.g., --gateway-server-service-location) would be too verbose, and the flag description already indicates that the flag customizes the location of the Service exposing the Gateway Server.

[frisso]

Hello @fra98
As a user, I'm definitely confused by the string "--server-service". Service of what? You know that is the gateway service, but this is not really evident from the flag.

[fra98]

/rebase test=true

[fra98]

@frisso
A good compromise between verbosity and clarity would be to add a short prefix (e.g., gw-) to the flag name.
In this case, a small refactoring is needed to change the other flags related to the gateway server/client, but I would leave that to a separate PR.

[fra98]

/test

[fra98]

/test

[cheina97]

/test

[fra98]

/rebase test=true

[cheina97]

/rebase test=true

[fra98]

/merge

[cheina97]

/rebase

[cheina97]

/merge