Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual node taints #2304

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Jan 26, 2024

Description

This pr adds the possibility to specify additional annotations and taint to be applied in the liqo node setting them in the VirtualNode spec

How Has This Been Tested?

  • locally

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Jan 26, 2024

/build

@aleoli aleoli force-pushed the aol/virtual-node-taints branch from 3daaa9e to e3de8d4 Compare January 26, 2024 16:29
@aleoli
Copy link
Member Author

aleoli commented Jan 26, 2024

/test

@aleoli aleoli requested review from cheina97 and fra98 January 26, 2024 16:55
@aleoli aleoli marked this pull request as ready for review January 26, 2024 16:55
@aleoli aleoli force-pushed the aol/virtual-node-taints branch from e3de8d4 to 9f60c02 Compare January 30, 2024 10:57
@aleoli aleoli force-pushed the aol/virtual-node-taints branch from 9f60c02 to 11d55cb Compare January 30, 2024 10:58
@aleoli
Copy link
Member Author

aleoli commented Jan 30, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Jan 30, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jan 30, 2024
@adamjensenbot adamjensenbot merged commit 4e44e8f into liqotech:master Jan 30, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants