You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
With the current liqoctl unpeer .... command remote cluster resources will be forcefully deleted, which means any running pod's in remote cluster will be deleted without any notice. In our case we run Machine Learning training in remote cluster for weeks/months by mistake if someone deletes FC CRD or execute liqoctl unpeer ML training will be deleted, which is not good.
Describe the solution you'd like
When using liqoctl,
When liqoctl unpeer command is executed, just disable OutgoingPeering, may be cordon the node so future pods will not be scheduled and delete FC CRD(which will delete virtual kubelet deployment) if no resource reflection.
If uses executes liqoctl unpeer --force then delete remote resource forcefully and delete FC CRD.
When FC CRD is deleted,
Block the deletion of the FC CRD till all the reflected resources are completed, but cordon the node so no new jobs will be scheduled.
If FC CRD was deleted with forcefully(not sure if we can differentiate in controller) then forcefully delete reflected resources.
This helps to avoid accident commands executions.
Describe alternatives you've considered
Additional context
I'm open for discussion and implementation once we agree together.
The text was updated successfully, but these errors were encountered:
Sharathmk99
changed the title
[Feature] Unpeer should delete remote resource gracefully rather than forcefully
[Feature] Unpeer should delete remote resource gracefully rather than force
May 31, 2023
Is your feature request related to a problem? Please describe.
With the current
liqoctl unpeer ....
command remote cluster resources will be forcefully deleted, which means any running pod's in remote cluster will be deleted without any notice. In our case we run Machine Learning training in remote cluster for weeks/months by mistake if someone deletes FC CRD or execute liqoctl unpeer ML training will be deleted, which is not good.Describe the solution you'd like
When using liqoctl,
When
liqoctl unpeer
command is executed, just disable OutgoingPeering, may be cordon the node so future pods will not be scheduled and delete FC CRD(which will delete virtual kubelet deployment) if no resource reflection.If uses executes
liqoctl unpeer --force
then delete remote resource forcefully and delete FC CRD.When FC CRD is deleted,
Block the deletion of the FC CRD till all the reflected resources are completed, but cordon the node so no new jobs will be scheduled.
If FC CRD was deleted with forcefully(not sure if we can differentiate in controller) then forcefully delete reflected resources.
This helps to avoid accident commands executions.
Describe alternatives you've considered
Additional context
I'm open for discussion and implementation once we agree together.
The text was updated successfully, but these errors were encountered: