fixup! Update pkg/liqo-controller-manager/internal-network/route/k8s.go

Author: cheina97

cmd/liqo-controller-manager/main.go

@@ -715,7 +715,6 @@ func main() {
 			os.Exit(1)
 		}
 
-		
 		wgServerRec := wggatewaycontrollers.NewWgGatewayServerReconciler(
 			mgr.GetClient(), mgr.GetScheme(), auxmgrExtNetworkPods.GetClient(), wgGatewayServerClusterRoleName)
 		if err = wgServerRec.SetupWithManager(mgr); err != nil {

pkg/liqo-controller-manager/internal-network/route/k8s.go

@@ -110,7 +110,7 @@ func forgeRoutePodDeleteFunction(pod *corev1.Pod, routecfg *networkingv1alpha1.R
 
 		if existingroute, exists := routeContainsPod(pod, &routecfg.Spec.Table.Rules[0]); exists {
 			routecfg.Spec.Table.Rules[0].Routes = slices.DeleteFunc(routecfg.Spec.Table.Rules[0].Routes, func(r networkingv1alpha1.Route) bool {
-				
+
 				return r.Dst == existingroute.Dst
 			})
 		}

pkg/route/routeconfiguration_controller.go

@@ -177,7 +177,7 @@ func (r *RouteConfigurationReconciler) SetupWithManager(mgr ctrl.Manager) error
 	if err != nil {
 		return err
 	}
-	
+
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&networkingv1alpha1.RouteConfiguration{}, builder.WithPredicates(filterByLabelsPredicate)).
 		Complete(r)

pkg/utils/geneve/netlink.go

@@ -19,6 +19,8 @@ import (
 	"net"
 
 	"github.com/vishvananda/netlink"
+
+	"github.com/liqotech/liqo/pkg/utils/kernel"
 )
 
 // EnsureGeneveInterfacePresence ensures that a geneve interface exists for the given internal node.
@@ -31,12 +33,16 @@ func EnsureGeneveInterfacePresence(interfaceName, localIP, remoteIP string, id u
 		}
 		remoteIPNet = remoteIPsNet[0]
 	}
-	return CreateGeneveInterface(interfaceName,
+	if err := CreateGeneveInterface(interfaceName,
 		net.ParseIP(localIP),
 		remoteIPNet,
 		id,
 		enableARP,
-	)
+	); err != nil {
+		return err
+	}
+
+	return kernel.EnableProxyARP(interfaceName)
 }
 
 // EnsureGeneveInterfaceAbsence ensures that a geneve interface does not exist for the given internal node.

pkg/utils/kernel/proxyarp.go

@@ -0,0 +1,36 @@
+// Copyright 2019-2024 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package kernel
+
+import "os"
+
+func generateARPFileName(ifname string) string {
+	return "/proc/sys/net/ipv4/conf/" + ifname + "/proxy_arp"
+}
+
+// EnableProxyARP enables proxy ARP on the host.
+// It writes 1 to /proc/sys/net/ipv4/conf/all/proxy_arp.
+func EnableProxyARP(ifname string) error {
+	file, err := os.OpenFile(generateARPFileName(ifname), os.O_WRONLY, 0o600)
+	if err != nil {
+		return err
+	}
+	defer file.Close()
+
+	if _, err := file.WriteString("1\n"); err != nil {
+		return err
+	}
+	return nil
+}