We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
it nearly works
it works fine on this repository (on the staging-deployment-works-internally tag) for internal PRs
staging-deployment-works-internally
it does not work yet for pull requests from forks, as these are funky
I need to set this up actions/checkout#518 (comment) so that an action can both
pull_request
pull_request_target
(this is not something that github actions likes you doing)
alternatively, I could just tell forks that they should create their own secrets for surge and it will work for them
surge
also, the surge step doesn't fail if the ENV variables SURGE_LOGIN and SURGE_KEY are unset. It should, then it would be obvious that it fails.
SURGE_LOGIN
SURGE_KEY
This sounds like a good compromise, and the action could report the URL in the same way that github pages reports the URL as an output
The text was updated successfully, but these errors were encountered:
could write surge description in a contirbuting guide
Sorry, something went wrong.
done, final commit is in 5ee5ff9
it just uses comments, not deployments, because there is no ref to use if the pull request comes from a fork
ref
alifeee
No branches or pull requests
it nearly works
it works fine on this repository (on the
staging-deployment-works-internally
tag) for internal PRsit does not work yet for pull requests from forks, as these are funky
I need to set this up actions/checkout#518 (comment) so that an action can both
pull_request
event)pull_request_target
event)(this is not something that github actions likes you doing)
alternatively, I could just tell forks that they should create their own secrets for
surge
and it will work for themalso, the
surge
step doesn't fail if the ENV variablesSURGE_LOGIN
andSURGE_KEY
are unset. It should, then it would be obvious that it fails.This sounds like a good compromise, and the action could report the URL in the same way that github pages reports the URL as an output
The text was updated successfully, but these errors were encountered: