-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix open redirect vulnerability #1899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for linode clusters with the clusterId. But does this also work if you do a manual install with your own domain? I haven't tried it but curious. Maybe we can keep it like this for Linode/managed installation but make it less strict if you use something else?
Good point. Updated the code so that it fits both scenarios. The regex expression is not directly constructed from the domainSuffix value provided in the apl chart values. |
Co-authored-by: jeho <[email protected]> (cherry picked from commit f180cc9)
This PR fixes an open redirect vulnerability affecting logged in users. The issue was caused by the nginx config in the oauth2-proxy ingress resource.
The redirect will be allowed only for domains matching a regex expression like the one below:
^([a-zA-Z0-9-]+\.){0,2}lke317513\.akamai-apl\.net(%2F)?(/.*)?$
The
lke317513\.akamai-apl\.net
is taking the value of cluster.domainSuffix provided in the apl installer chart values.You can test the expression here: https://regex101.com/r/Yk6RMh/1