Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure rootDir and increase retry timeout #1882

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix: ensure rootDir and increase retry timeout #1882

merged 2 commits into from
Jan 3, 2025

Conversation

j-zimnowoda
Copy link
Contributor

@j-zimnowoda j-zimnowoda commented Jan 2, 2025

This code change:

  • ensures setting correct current working directory
  • increases waitTillGitRepoAvailable timeout to accommodate DNS and Certificate request delays
  • fixes the Retrying in undefined ms log message
  • improve readability of error message once performing git ls-remote command

Testing methodology:

  • I was able to reproduce the issue by deploying the following the APL-449-reproduce branch (fix: test #1884)
  • I tested the change by deploying the APL-449-test branch, which exactly the same as this PR except I lowered down the retries parameter.

@j-zimnowoda j-zimnowoda marked this pull request as ready for review January 2, 2025 15:56
Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it by merging it in my own branch, and it works.

Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked ✅

@j-zimnowoda j-zimnowoda merged commit 4ab74e0 into main Jan 3, 2025
18 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-449 branch January 3, 2025 11:35
Ani1357 pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants