Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rule expr for db backup prom rules #1866

Merged
merged 4 commits into from
Dec 17, 2024
Merged

fix: rule expr for db backup prom rules #1866

merged 4 commits into from
Dec 17, 2024

Conversation

srodenhuis
Copy link
Contributor

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@j-zimnowoda j-zimnowoda self-assigned this Dec 16, 2024
@CasLubbers CasLubbers self-assigned this Dec 16, 2024
@j-zimnowoda j-zimnowoda self-requested a review December 17, 2024 14:07
j-zimnowoda
j-zimnowoda approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

image

@j-zimnowoda j-zimnowoda requested a review from Ani1357 December 17, 2024 14:09
@j-zimnowoda j-zimnowoda merged commit 5586cd9 into main Dec 17, 2024
5 checks passed
@j-zimnowoda j-zimnowoda deleted the sr-fix-db-rules branch December 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

@CasLubbers CasLubbers Awaiting requested review from CasLubbers

Assignees

@j-zimnowoda j-zimnowoda

@CasLubbers CasLubbers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srodenhuis @j-zimnowoda @Ani1357 @CasLubbers