Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add path for gitea #1835

Merged
merged 3 commits into from
Dec 3, 2024
Merged

feat: add path for gitea #1835

merged 3 commits into from
Dec 3, 2024

Conversation

CasLubbers
Copy link
Contributor

@CasLubbers CasLubbers commented Dec 3, 2024 •
edited
Loading

Ani1357
Ani1357 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by upgrading core, api and console on existing cluster and accessing gitea afterwards. Works as expected.

dennisvankekem
dennisvankekem approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in console for small note

@CasLubbers CasLubbers merged commit 6e62d6a into main Dec 3, 2024
5 checks passed
@CasLubbers CasLubbers deleted the APL-416 branch December 3, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisvankekem dennisvankekem dennisvankekem approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

@merll merll Awaiting requested review from merll

@ElderMatt ElderMatt Awaiting requested review from ElderMatt

Assignees

@dennisvankekem dennisvankekem

@Ani1357 Ani1357

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CasLubbers @dennisvankekem @Ani1357