Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppet Lint breaks STDIO transport on error #132

Closed
glennsarti opened this issue May 26, 2019 · 0 comments · Fixed by #133
Closed

Puppet Lint breaks STDIO transport on error #132

glennsarti opened this issue May 26, 2019 · 0 comments · Fixed by #133
Milestone
0.19.1

Comments

@glennsarti
Copy link
Contributor

glennsarti commented May 26, 2019 •
edited
Loading

Initially raised in puppetlabs/puppet-vscode#436

If puppet-lint experiences a catastrophic error it polutes STDOUT with Whoops! It looks like puppet-lint has encountered an error that it doesn't\nknow how to handle. Please open an issue at https: "//github.com/rodjek/puppet-lint\nand paste the foll… which causes the LSP STDIO transport to fail in the client.

All STDIO output from puppet-lint should be suppressed
@glennsarti glennsarti added this to the 0.20.0 milestone May 26, 2019
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue May 26, 2019
@glennsarti
(puppetlabsGH-132) Suppress $stdout usage for STDIO transport
0b5d8de 
Previously some libraries, like puppet-lint, would use $stdout to output
information to STDOUT instead of using a logging mechanism which could be
monkey patched or configured to not output.  This commit updates the STDIO
transport to reassign the global $stdout variable to a null stream.
@glennsarti glennsarti mentioned this issue May 26, 2019
Merged
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue May 26, 2019
@glennsarti
(puppetlabsGH-132) Suppress $stdout usage for STDIO transport
4a0d970 
Previously some libraries, like puppet-lint, would use $stdout to output
information to STDOUT instead of using a logging mechanism which could be
monkey patched or configured to not output.  This commit updates the STDIO
transport to reassign the global $stdout variable to a null stream.
jpogran pushed a commit that referenced this issue May 28, 2019
Merge pull request #133 from glennsarti/gh-132-fix-stdio
59b8306 
(GH-132) Suppress $stdout usage for STDIO transport
@glennsarti glennsarti modified the milestones: 0.20.0, 0.19.1 May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.1
Development

Successfully merging a pull request may close this issue.

(GH-132) Suppress $stdout usage for STDIO transport glennsarti/puppet-editor-services
1 participant
@glennsarti