Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent file cache doesn't appear to work on Mac #10

Closed
glennsarti opened this issue Apr 19, 2018 · 2 comments
Closed

Persistent file cache doesn't appear to work on Mac #10

glennsarti opened this issue Apr 19, 2018 · 2 comments
Labels
bug Something isn't working
Milestone
0.12.0

Comments

@glennsarti
Copy link
Contributor

James mentioned that the language server crashed on Mac with the file cache enabled. Need to repro and investigate
@glennsarti glennsarti added the bug Something isn't working label Apr 19, 2018
@glennsarti
Copy link
Contributor Author

repro'd. The Temp directory detection was Windows only :-(

glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Apr 30, 2018
@glennsarti
(puppetlabsGH-10) Disable the file cache if temp directory doesn't exist
f601005 
Previously the persistent file cache would crash if the temporary directory
could not be detected, or did not exist.  This commit changes the detection to
be cross platform supported and adds error detection if the cache directory
could not be created.  If the the cache directory is unable to be created all
calls to the persistent file cache then emulate as if the cache is empty thereby
still allowing the language server to operate.  This commit also adds tests for
this scenario.
@glennsarti glennsarti added this to the 0.12.0 milestone Apr 30, 2018
@glennsarti glennsarti changed the title persistent file cache doesn't appear to work on Mac Persistent file cache doesn't appear to work on Mac Apr 30, 2018
@glennsarti
Copy link
Contributor Author

Relates to #21

jpogran added a commit that referenced this issue May 1, 2018
@jpogran
Merge pull request #15 from glennsarti/fix-unix-loading
05e0706 
(GH-10)(GH-14) Fix unix loading for language server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
1 participant
@glennsarti