Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate reparsing in SVG Rendering native example #161

Closed
simbleau opened this issue Apr 3, 2022 · 1 comment · Fixed by #162
Closed

Duplicate reparsing in SVG Rendering native example #161

simbleau opened this issue Apr 3, 2022 · 1 comment · Fixed by #162

Comments

@simbleau
Copy link
Member

simbleau commented Apr 3, 2022

render_svg() in the example is loading and reparsing the file every frame, which was definitely not intended... I'll make a PR tomorrow or soon when I have time to fix that.

@raphlinus
Copy link
Contributor

Heh yes. One reason I haven't done anything about this is that we intend to put in an API for scene fragments. With that API, you'd load, parse, and create a fragment once, then render that fragment (possibly with different scale, clip, blend, etc) as many times as you like.

But that won't land for a bit so it makes sense to have something in place to get meaningful measurements.

@simbleau simbleau changed the title SLOW SVG Rendering in native example Duplicate reparsing in SVG Rendering native example Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants