Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix omniauth-oauth2 1.4.0 compatibility #13

Closed
pravi opened this issue Nov 7, 2016 · 6 comments
Closed

fix omniauth-oauth2 1.4.0 compatibility #13

pravi opened this issue Nov 7, 2016 · 6 comments

Comments

@pravi
Copy link

pravi commented Nov 7, 2016

see https://gitlab.com/gitlab-com/support-forum/issues/1270 for background discussion
@pravi
Copy link
Author

pravi commented Nov 7, 2016

This is how omniauth-google-oauth2 was fixed zquestz/omniauth-google-oauth2#205

@linchus
Copy link
Owner

linchus commented Nov 7, 2016

Thanks for report.
I'll add backward compatibility for omniauth-oauth2 soon.

@linchus
Copy link
Owner

linchus commented Nov 7, 2016

I have tested omniauth-gitlab 1.0.2 with omniauth-oauth2 1.4.0 and it works with gitlab.com.

Could you provide more details?

@pravi
Copy link
Author

pravi commented Nov 8, 2016

It may then be a bug in how gitlab.com is using omniauth-gitlab, https://gitlab.com/gitlab-com/support-forum/issues/1270 has details.

@stanhu
Copy link
Contributor

stanhu commented Nov 8, 2016

omniauth-gitlab 1.0.1 does not work, but 1.0.2 does. I believe this is a dupe of #10.

@pravi
Copy link
Author

pravi commented Nov 8, 2016

Updating to 1.0.2 fixed the issue.

@pravi pravi closed this as completed Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pravi @stanhu @linchus