Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to 0.13 causes error:true to be set on Express spans. #33

Closed
austinlparker opened this issue Jan 14, 2021 · 5 comments · Fixed by #34
Closed

Updating to 0.13 causes error:true to be set on Express spans. #33

austinlparker opened this issue Jan 14, 2021 · 5 comments · Fixed by #34
Assignees

Comments

@austinlparker
Copy link

Describe the bug
After updating to 0.13.0, the error attribute is set to true on Express HTTP spans.

To Reproduce
Install express, launcher.

const {
  lightstep,
  opentelemetry,
} = require('lightstep-opentelemetry-launcher-node');

const sdk = lightstep.configureOpenTelemetry({
  accessToken: '<token>',
  serviceName: 'launcher-test',
});

sdk.start().then(() => {
  const express = require('express')
  const app = express()
  const port = 3000

  app.get('/', (req, res) => {
    res.send('Hello World!')
  })

  app.listen(port, () => {
    console.log(`Example app listening at http://localhost:${port}`)
  })
});

Expected behavior
A GET request should produce a span without an error.

Additional context

image

@mwear
Copy link
Contributor

mwear commented Jan 14, 2021

@obecny: Does v0.14.0 contain this PR: open-telemetry/opentelemetry-js#1751? If not, will that fix this issue?

@obecny
Copy link
Contributor

obecny commented Jan 14, 2021

@austinlparker pls use v0.14 of core and 0.12 of contrib, ignore v.0.13 of core

hmm I mislead the version of launcher and version of otel.
Anyway which version of express plugin are you using ?

@mwear
Copy link
Contributor

mwear commented Jan 14, 2021

Given that launcher includes @opentelemetry/plugins-node-core-and-contrib v0.12.0, I'd assume it's the version of the express plugin that it depends on (also v0.12.0).

@dobesv
Copy link
Contributor

dobesv commented Jan 15, 2021

Having a similar problem with koa over here, although we are not using the koa plugin, just plain http.

@mwear
Copy link
Contributor

mwear commented Jan 22, 2021

This is fixed in the v0.13.1 release: https://www.npmjs.com/package/lightstep-opentelemetry-launcher-node/v/0.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants