From b81634f5bf7eacef70744a8ddd347af89d056704 Mon Sep 17 00:00:00 2001 From: Patrick Facheris Date: Fri, 17 Mar 2023 08:39:56 -0400 Subject: [PATCH] remove access token length check --- launcher/config.go | 5 ----- launcher/config_test.go | 29 ----------------------------- 2 files changed, 34 deletions(-) diff --git a/launcher/config.go b/launcher/config.go index bb45e96d..8facf0c0 100644 --- a/launcher/config.go +++ b/launcher/config.go @@ -287,11 +287,6 @@ func validateConfiguration(c Config) error { } } - // TODO(@tobert) will probably break on some providers but seems fine for my use cases right now - if accessTokenLen > 0 && (accessTokenLen != 32 && accessTokenLen != 84 && accessTokenLen != 104 && accessToken(c) != "developer") { - return fmt.Errorf("invalid configuration: access token length incorrect. Ensure token is set correctly") - } - return nil } diff --git a/launcher/config_test.go b/launcher/config_test.go index b94bf376..db6e9b04 100644 --- a/launcher/config_test.go +++ b/launcher/config_test.go @@ -35,7 +35,6 @@ import ( ) const ( - expectedAccessTokenLengthError = "invalid configuration: access token length incorrect. Ensure token is set correctly" expectedAccessTokenMissingError = "invalid configuration: access token missing, must be set when reporting to ingest.lightstep.com" expectedTracingDisabledMessage = "tracing is disabled by configuration: no endpoint set" expectedMetricsDisabledMessage = "metrics are disabled by configuration: no endpoint set" @@ -207,34 +206,6 @@ func (suite *testSuite) TestInvalidMetricDefaultAccessToken() { ) } -func (suite *testSuite) testInvalidAccessToken(opts ...Option) { - lsOtel := ConfigureOpentelemetry( - append(opts, - WithLogger(&suite.testLogger), - WithServiceName("test-service"), - )..., - ) - defer lsOtel.Shutdown() - - suite.requireLogContains(expectedAccessTokenLengthError) -} - -func (suite *testSuite) TestInvalidTraceAccessTokenLength() { - suite.testInvalidAccessToken( - append(suite.insecureTraceEndpointOptions(), - WithAccessToken("1234"), - )..., - ) -} - -func (suite *testSuite) TestInvalidMetricAccessTokenLength() { - suite.testInvalidAccessToken( - append(suite.bothInsecureEndpointOptions(), - WithAccessToken("1234"), - )..., - ) -} - func (suite *testSuite) testEndpointDisabled(expected string, opts ...Option) { lsOtel := ConfigureOpentelemetry( append(opts,