Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements in concurrent update code path #377

Closed
jmacd opened this issue Feb 13, 2023 · 0 comments · Fixed by #384
Closed

Performance improvements in concurrent update code path #377

jmacd opened this issue Feb 13, 2023 · 0 comments · Fixed by #384

Comments

@jmacd
Copy link
Contributor

jmacd commented Feb 13, 2023

Is your feature request related to a problem? Please describe.

Improve the syncstate code path that locates the Aggregator given the Attribute Set for an instrument. This is currently contentious is a couple of internal Lightstep binaries.

Describe the solution you'd like

  1. Replace RWMutex with Mutex
  2. Decouple map lock from record initialization, use a sync.Once to initialize
  3. Option to ignore fingerprint collisions

Describe alternatives you've considered
n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant