Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script-path validation unit tests for group_key witness scenarios #511

Closed
dstadulis opened this issue Sep 19, 2023 · 3 comments · Fixed by #542 or #549
Closed

Add script-path validation unit tests for group_key witness scenarios #511

dstadulis opened this issue Sep 19, 2023 · 3 comments · Fixed by #542 or #549
Assignees
@jharveyb
Milestone
v0.4

Comments

@dstadulis
Copy link
Contributor

@jharveyb to list issue deliverables
@dstadulis dstadulis added testing VM virtual machine labels Sep 19, 2023
@dstadulis dstadulis changed the title [Enhance]: Add script path validation unit tests for group_key witness scenarios Add script path validation unit tests for group_key witness scenarios Sep 21, 2023
@dstadulis dstadulis changed the title Add script path validation unit tests for group_key witness scenarios Add script-path validation unit tests for group_key witness scenarios Sep 21, 2023
@dstadulis dstadulis moved this from 🆕 New to 🔖 Ready in Taproot-Assets Project Board Sep 28, 2023
@dstadulis dstadulis moved this from 🔖 Ready to 💇‍♂️Needs Shaping in Taproot-Assets Project Board Sep 28, 2023
@Neil-LL Neil-LL moved this from 💇‍♂️Needs Shaping to 🏗 In progress in Taproot-Assets Project Board Oct 2, 2023
@dstadulis dstadulis added the v0.3 label Oct 2, 2023
@jharveyb
Copy link
Contributor

jharveyb commented Oct 3, 2023 •
edited by dstadulis
Loading

In descending priority order:

  • Manually generate group witness with a non-empty tapscript root, and verify witness via normal minting flow
  • Exercise new VM validation branches
  • Exercise group and group anchor verifiers + sortassets
  • Coverage for GroupPubKey(), DeriveGroupKey(), and new Has/NeedsGenesisWitnessForGroup helpers
  • Exercise new branches in proof.Verify() concerning group key validation
  • Validate group key reveal handling in committedProofs()
  • Validate store & load of multi-element group witnesses

@jharveyb jharveyb mentioned this issue Oct 3, 2023
Closed
@Roasbeef Roasbeef moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Oct 3, 2023
@Roasbeef Roasbeef mentioned this issue Oct 3, 2023
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Oct 3, 2023
@jharveyb jharveyb reopened this Oct 3, 2023
@jharveyb jharveyb moved this from ✅ Done to 🏗 In progress in Taproot-Assets Project Board Oct 3, 2023
@jharveyb jharveyb mentioned this issue Oct 4, 2023
Merged
8 tasks
@jharveyb
Copy link
Contributor

jharveyb commented Nov 3, 2023 •
edited by dstadulis
Loading

Mostly address by #598, further plans detailed in #549

@Roasbeef Roasbeef added this to the v0.4 milestone Nov 6, 2023
@jharveyb jharveyb removed testing v0.3 VM virtual machine labels Nov 21, 2023
@jharveyb jharveyb moved this from 🏗 In progress to 🔖 Ready in Taproot-Assets Project Board Nov 21, 2023
@jharveyb
Copy link
Contributor

May have an issue validating when the meta field was empty on the CLI.

@jharveyb jharveyb moved this from 🔖 Ready to 🏗 In progress in Taproot-Assets Project Board Dec 18, 2023
@jharveyb jharveyb moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Dec 19, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jharveyb jharveyb

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.4
3 participants
@Roasbeef @dstadulis @jharveyb