Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add channel_id to SpendableOutputs event #2480

Closed
tlulu opened this issue Aug 7, 2023 · 1 comment · Fixed by #2511
Closed

Add channel_id to SpendableOutputs event #2480

tlulu opened this issue Aug 7, 2023 · 1 comment · Fixed by #2511
Labels
good first issue Good for newcomers
Milestone
0.2

Comments

@tlulu
Copy link

tlulu commented Aug 7, 2023 •
edited
Loading

What

There currently isn't a way to link SpendableOutputs and ChannelMonitor. One can get around this by checking a ChannelMonitor's claimable balances

ldkService.getChannelMonitors().filter { it._claimable_balances.isEmpty() }

Why

The channel_id should be added to SpendableOutputs event which could be persisted so clients of LDK can:

  1. easily prune its corresponding ChannelMonitor after processing this event
  2. confirm with a database query if a ChannelMonitor is safe to prune
  3. reconcile funds using database queries
@TheBlueMatt TheBlueMatt mentioned this issue Aug 13, 2023
Closed
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Aug 13, 2023
@TheBlueMatt TheBlueMatt added this to the 0.1.1 milestone Aug 13, 2023
@jbesraa
Copy link
Contributor

jbesraa commented Aug 21, 2023

picking this up please!

@jbesraa jbesraa mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Add channel_id to SpendableOutputs event jbesraa/rust-lightning
3 participants
@TheBlueMatt @tlulu @jbesraa