Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune full channels if either direction is not updating #1671

Closed
TheBlueMatt opened this issue Aug 15, 2022 · 2 comments · Fixed by #1735
Closed

Prune full channels if either direction is not updating #1671

TheBlueMatt opened this issue Aug 15, 2022 · 2 comments · Fixed by #1735
Labels
good first issue Good for newcomers
Milestone
0.1

Comments

@TheBlueMatt
Copy link
Collaborator

ie implement the change at lightning/bolts#1014 we also need to keep track of channels we removed so we don't immediately re-add them.
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Aug 15, 2022
@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Aug 15, 2022
@naumenkogs
Copy link
Contributor

I was not sure if i should take good first issues, but anyway decided to work on it and planning to open a PR in a day or two :)

@TheBlueMatt
Copy link
Collaborator Author

Awesome! Probably makes sense to base this off of #1649 just to avoid conflicts, or at least make sure its not going to conflict too heavily there, though I don't think we want to mark such channels as perm-failed.

@naumenkogs naumenkogs mentioned this issue Sep 9, 2022
Merged
@naumenkogs naumenkogs mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Prune channels if either not updated + track pruning time naumenkogs/rust-lightning
2 participants
@TheBlueMatt @naumenkogs