Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random CLTV offsets (or max CLTV offsets) during route calculation #158

Closed
TheBlueMatt opened this issue Sep 6, 2018 · 5 comments
Closed
Labels
good first issue Good for newcomers Privacy

Comments

@TheBlueMatt
Copy link
Collaborator

As suggested by BOLT 7 in "Recommendations for Routing" to avoid making it obvious which hops a route is taking.

@TheBlueMatt
Copy link
Collaborator Author

Note we should do the same for the value sent.

@TheBlueMatt
Copy link
Collaborator Author

Done in #1286.

@tnull
Copy link
Contributor

tnull commented May 16, 2022

Note we should do the same for the value sent.

Do we still want some form of fee randomization/overpayment? On the one hand, adding the exact fees might give something away to an adversary that is able to guess the actual payment amount to be delivered correctly. On the other, it is questionable how often this would be the case and whether these few instances would actually justify the losing some amount in overpaid fees and making the routing logic more complex.

@TheBlueMatt
Copy link
Collaborator Author

Oh good point, yea, maybe lets open an issue to track it, but I think I agree with you there may not be a ton of value in it. One question is if we should randomize in the sub-sat range - we should maybe investigate how much invoices in the wild have 0 msats or any other "round numbers" where we should randomize a bit to add noise.

@TheBlueMatt
Copy link
Collaborator Author

#1482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Privacy
Projects
None yet
Development

No branches or pull requests

3 participants