Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move object reads to KVStorePersister post-1417 #1427

Closed
TheBlueMatt opened this issue Apr 16, 2022 · 2 comments
Closed

Move object reads to KVStorePersister post-1417 #1427

TheBlueMatt opened this issue Apr 16, 2022 · 2 comments
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

See #1417 (comment)

@johncantrell97
Copy link
Contributor

Happy to continue on this after #1417 goes in. I actually already implemented it in Sensei because it seemed like you didn't want in ldk. I added a read and a list method since read_channelmonitors needs to be able to list all keys/filenames.

Here's what I did, let me know if you think it's roughly what you'd want to add to KVStorePersister for this issue:

https://github.com/L2-Technology/sensei/pull/37/files#diff-af422d8a9ab5e8778884033d55578f060f9d14dde012232f4faeb2b8a49cec92R12

@tnull
Copy link
Contributor

tnull commented Nov 14, 2023

Closing as done in #2472.

@tnull tnull closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants