Skip to content

Commit 0c59ff1

Browse files
authored
Merge pull request #146 from mdedetrich/set-to-jdk-8
2 parents 1aef3e4 + 661f860 commit 0c59ff1

File tree

5 files changed

+25
-4
lines changed

5 files changed

+25
-4
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
fail-fast: false
1111
matrix:
12-
java: [11, 17]
12+
java: [8, 11, 17]
1313
runs-on: ubuntu-latest
1414
steps:
1515
- uses: actions/checkout@v2

.scala-steward.conf

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
updates.ignore = [
2+
// These updates are ignored to ensure JDK 1.8 support
3+
{ groupId = "org.eclipse.jgit", artifactId = "org.eclipse.jgit" },
4+
{ groupId = "ch.qos.logback", artifactId = "logback-classic"}
5+
]

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
A tool for generating bytecode diffs
44

5-
Requires JDK 11+
5+
Requires JDK 8+
66

77
## About
88

build.sbt

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ lazy val core = (
3434
"org.ow2.asm" % "asm" % AsmVersion,
3535
"org.ow2.asm" % "asm-util" % AsmVersion,
3636
"org.scala-lang" % "scalap" % System.getProperty("scalap.version", scalaVersion.value),
37-
"org.eclipse.jgit" % "org.eclipse.jgit" % "6.7.0.202309050840-r",
37+
"org.eclipse.jgit" % "org.eclipse.jgit" % "5.13.2.202306221912-r",
3838
"org.slf4j" % "slf4j-api" % "2.0.9",
3939
"org.slf4j" % "log4j-over-slf4j" % "2.0.9", // for any java classes looking for this
40-
"ch.qos.logback" % "logback-classic" % "1.4.11",
40+
"ch.qos.logback" % "logback-classic" % "1.3.11",
4141
"org.scalatest" %% "scalatest" % "3.2.17" % Test,
4242
),
4343
name := buildName + "-core",
+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import org.eclipse.jgit.api.Git
2+
import org.scalatest.flatspec.AnyFlatSpec
3+
import org.scalatest.matchers.should.Matchers
4+
import org.slf4j.LoggerFactory
5+
6+
final class JDK8SmokeTest extends AnyFlatSpec with Matchers {
7+
behavior of "Testing dependencies are compiled with JDK 1.8"
8+
9+
it should "make sure slf4j/logback works" in {
10+
LoggerFactory.getLogger(getClass.getName)
11+
}
12+
13+
it should "make sure JGit works" in {
14+
Git.init
15+
}
16+
}

0 commit comments

Comments
 (0)