Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: expose x-request-id in CORS headers #490

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Conversation

dirkdev98
Copy link
Member

Closes #487

@github-actions
Copy link
Contributor

==== C8 test coverage ====
Statements: 70.2% ( 18375/26174 )
Branches : 71.89% ( 2174 /3024 )
Functions : 70.33% ( 678 /964 )
Lines : 70.2% ( 18375 /26174 )

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 14

Total benchmarks: 13
          Passed: 13
          Failed: 0
-----------
lbu validator simple                    5000000  iterations      449  ns/op
yup validator simple                      20000  iterations    59750  ns/op
fastest-validator validator simple     10000000  iterations      135  ns/op
lbu validator nested                      50000  iterations    49217  ns/op
yup validator nested                       5000  iterations   397326  ns/op
fastest-validator validator nested      2000000  iterations      829  ns/op
logger - strings                         500000  iterations     2328  ns/op
logger - objects                         500000  iterations     2792  ns/op
logger - deep objects                    500000  iterations     4413  ns/op
uuid                                    2000000  iterations      553  ns/op
uuid.isValid                           10000000  iterations      165  ns/op
isNil                                 500000000  iterations        0  ns/op
isPlainObject                         100000000  iterations       19  ns/op

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 15

Total benchmarks: 13
          Passed: 13
          Failed: 0
-----------
lbu validator simple                    5000000  iterations      461  ns/op
yup validator simple                      20000  iterations    61256  ns/op
fastest-validator validator simple     10000000  iterations      135  ns/op
lbu validator nested                      50000  iterations    47389  ns/op
yup validator nested                       5000  iterations   397377  ns/op
fastest-validator validator nested      2000000  iterations      831  ns/op
logger - strings                         500000  iterations     2260  ns/op
logger - objects                         500000  iterations     2734  ns/op
logger - deep objects                    500000  iterations     4262  ns/op
uuid                                    2000000  iterations      586  ns/op
uuid.isValid                           10000000  iterations      161  ns/op
isNil                                 500000000  iterations        0  ns/op
isPlainObject                         100000000  iterations       19  ns/op

@dirkdev98 dirkdev98 merged commit d6a6794 into main Nov 14, 2020
@dirkdev98 dirkdev98 deleted the feat/expose-headers branch November 14, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server: add Access-Control-Expose-Headers to cors handler
1 participant