Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-gen: fix deletedAt check with Date in the future #483

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

dirkdev98
Copy link
Member

Closes #482

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020

==== C8 test coverage ====
Statements: 70.15% ( 18291/26075 )
Branches : 71.91% ( 2166 /3012 )
Functions : 70.37% ( 677 /962 )
Lines : 70.15% ( 18291 /26075 )

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020

==== Benchmark result ====

Node.js version: 14

Total benchmarks: 13
          Passed: 13
          Failed: 0
-----------
lbu validator simple                    5000000  iterations      471  ns/op
yup validator simple                      20000  iterations    64147  ns/op
fastest-validator validator simple     10000000  iterations      142  ns/op
lbu validator nested                      50000  iterations    48138  ns/op
yup validator nested                       5000  iterations   436448  ns/op
fastest-validator validator nested      2000000  iterations      967  ns/op
logger - strings                         500000  iterations     2594  ns/op
logger - objects                         500000  iterations     2861  ns/op
logger - deep objects                    500000  iterations     4500  ns/op
uuid                                    2000000  iterations      579  ns/op
uuid.isValid                           10000000  iterations      174  ns/op
isNil                                 500000000  iterations        0  ns/op
isPlainObject                          50000000  iterations       20  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020

==== Benchmark result ====

Node.js version: 15

Total benchmarks: 13
          Passed: 13
          Failed: 0
-----------
lbu validator simple                    5000000  iterations      467  ns/op
yup validator simple                      20000  iterations    61658  ns/op
fastest-validator validator simple     10000000  iterations      139  ns/op
lbu validator nested                      50000  iterations    48700  ns/op
yup validator nested                       5000  iterations   422648  ns/op
fastest-validator validator nested      2000000  iterations      862  ns/op
logger - strings                         500000  iterations     2338  ns/op
logger - objects                         500000  iterations     2995  ns/op
logger - deep objects                    200000  iterations     5144  ns/op
uuid                                    2000000  iterations      602  ns/op
uuid.isValid                           10000000  iterations      166  ns/op
isNil                                 500000000  iterations        0  ns/op
isPlainObject                         100000000  iterations       19  ns/op

@dirkdev98 dirkdev98 merged commit d2d8d51 into main Nov 7, 2020
@dirkdev98 dirkdev98 deleted the fix/deleted-at branch November 7, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code-gen: deletedAt should check > now()
1 participant