Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-gen: flatten output #460

Merged
merged 1 commit into from
Nov 1, 2020
Merged

code-gen: flatten output #460

merged 1 commit into from
Nov 1, 2020

Conversation

dirkdev98
Copy link
Member

Means less files that changed in Git diffs, and easier to use exports while still allowing tree-shaking.

BREAKING CHANGE: rewrite your references to validators or custom structure usage.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

==== C8 test coverage ====
Statements: 70.3% ( 17956/25542 )
Branches : 71.52% ( 2104 /2942 )
Functions : 70.69% ( 668 /945 )
Lines : 70.3% ( 17956 /25542 )

Means less files that changed in Git diffs, and easier to use exports while still allowing tree-shaking.

BREAKING CHANGE: rewrite your references to validators or custom structure usage.
@dirkdev98 dirkdev98 force-pushed the feat/flatten-code-gen-output branch from 9f9c99d to 7e71f05 Compare November 1, 2020 11:11
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

==== Benchmark result ====

Node.js version: 15

Total benchmarks: 9
          Passed: 9
          Failed: 0
-----------
object validator simple      5000000  iterations     452  ns/op
object validator nested        50000  iterations   43503  ns/op
logger - strings              500000  iterations    2008  ns/op
logger - objects              500000  iterations    2690  ns/op
logger - deep objects         500000  iterations    4388  ns/op
uuid                         2000000  iterations     550  ns/op
uuid.isValid                10000000  iterations     148  ns/op
isNil                      500000000  iterations       0  ns/op
isPlainObject              100000000  iterations      16  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

==== Benchmark result ====

Node.js version: 14

Total benchmarks: 9
          Passed: 9
          Failed: 0
-----------
object validator simple      2000000  iterations     532  ns/op
object validator nested        50000  iterations   49269  ns/op
logger - strings              500000  iterations    2338  ns/op
logger - objects              500000  iterations    2747  ns/op
logger - deep objects         500000  iterations    4826  ns/op
uuid                         2000000  iterations     549  ns/op
uuid.isValid                10000000  iterations     173  ns/op
isNil                      500000000  iterations       0  ns/op
isPlainObject              100000000  iterations      20  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2020

==== C8 test coverage ====
Statements: 70.3% ( 17956/25542 )
Branches : 71.52% ( 2104 /2942 )
Functions : 70.69% ( 668 /945 )
Lines : 70.3% ( 17956 /25542 )

@dirkdev98 dirkdev98 merged commit 0590b6c into main Nov 1, 2020
@dirkdev98 dirkdev98 deleted the feat/flatten-code-gen-output branch November 1, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant