Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LID-14 Insecure BytesLib dependency in Lido.sol #247

Closed
kadmil opened this issue Dec 13, 2020 · 2 comments
Closed

LID-14 Insecure BytesLib dependency in Lido.sol #247

kadmil opened this issue Dec 13, 2020 · 2 comments

Comments

@kadmil
Copy link
Contributor

kadmil commented Dec 13, 2020

The BytesLib version used in the current (v0.2.1-rc.0) implementation has a critical vulnerability in the BytesLib.slice method. The audit suggests ensuring Lido from passing any user-supplied input to the arguments of BytesLib.slice.
@skozin
Copy link
Member

skozin commented Dec 15, 2020 •
edited
Loading

This is not currently exploitable since we're not supplying user input to BytesLib.slice, but we'll need to update the dependency as soon as we update our codebase to a newer Solidity version (the current one, v0.4.x, is not supported by the fixed dependency version).

@skozin skozin mentioned this issue Feb 3, 2023
Merged
@TheDZhon
Copy link
Contributor

Resolved in https://github.com/lidofinance/lido-dao/releases/tag/v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TheDZhon @skozin @kadmil and others