You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From the beginning, I don't like the name RWops, because it's a bunch of letters, which at first glance you don't know what they mean. Also, the formatting of these names does not follow the naming convention used in the rest of the library — RwOps would be more appropriate.
Since read/write operations are about reading and writing data to any stream, why not just call it SDL_Stream? If you do this, the clarity will be high, the purpose of the functions will be clearly visible. The functions would rename to:
There is a base class in the Object Pascal standard library, which is a similar abstraction to RWops. Any other streams inherit from it, including streams for files, arbitrary memory buffers, strings etc.. Its name is just TStream (Free Pascal, Delphi) — hence my suggestion to replace RWops simply with Stream since it also applies to arbitrary streams and data buffers.
I like your proposal — IOStream is clear and unambiguous.
(There is also SDL_AudioStream which is some king of IO. I thought it would be elegant to create AudioStream on top of RWops.
but OTHO, as soon as you'll try to grep/find to a stream function, you'll end up with much more occurrence. so let's not change that)
In short, I'm fine with the current name / don't mind much if that changes.
From the beginning, I don't like the name
RWops
, because it's a bunch of letters, which at first glance you don't know what they mean. Also, the formatting of these names does not follow the naming convention used in the rest of the library —RwOps
would be more appropriate.Since read/write operations are about reading and writing data to any stream, why not just call it
SDL_Stream
? If you do this, the clarity will be high, the purpose of the functions will be clearly visible. The functions would rename to:What do you think about it? This issue is related to the #6569.
The text was updated successfully, but these errors were encountered: