Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL API renaming: SDL_surface.h #6884

Closed
slouken opened this issue Dec 23, 2022 · 2 comments
Closed

SDL API renaming: SDL_surface.h #6884

slouken opened this issue Dec 23, 2022 · 2 comments

Comments

@slouken
Copy link
Collaborator

slouken commented Dec 23, 2022

Here are proposed name changes for functions in SDL_render.h, per discussion in #6569

SDL_ConvertPixels
SDL_ConvertSurface
SDL_ConvertSurfaceFormat
SDL_CreateSurface
SDL_CreateSurfaceFrom
SDL_DuplicateSurface
SDL_FillRect => SDL_FillSurfaceRect
SDL_FillRects => SDL_FillSurfaceRects
SDL_FreeSurface => SDL_DestroySurface
SDL_GetClipRect => SDL_GetSurfaceClipRect
SDL_GetColorKey => SDL_GetSurfaceColorKey
SDL_GetSurfaceAlphaMod
SDL_GetSurfaceBlendMode
SDL_GetSurfaceColorMod
SDL_GetYUVConversionMode
SDL_GetYUVConversionModeForResolution
SDL_HasColorKey => SDL_SurfaceHasColorKey
SDL_HasSurfaceRLE => SDL_SurfaceHasRLE
SDL_LoadBMP_RW
SDL_LockSurface
SDL_LowerBlit => SDL_BlitSurfaceUnchecked
SDL_LowerBlitScaled => SDL_BlitSurfaceUncheckedScaled
SDL_PremultiplyAlpha
SDL_SaveBMP_RW
SDL_SetClipRect => SDL_SetSurfaceClipRect
SDL_SetColorKey => SDL_SetSurfaceColorKey
SDL_SetSurfaceAlphaMod
SDL_SetSurfaceBlendMode
SDL_SetSurfaceColorMod
SDL_SetSurfacePalette
SDL_SetSurfaceRLE
SDL_SetYUVConversionMode
SDL_SoftStretch
SDL_SoftStretchLinear
SDL_UnlockSurface
SDL_UpperBlit => SDL_BlitSurface
SDL_UpperBlitScaled => SDL_BlitSurfaceScaled

@libsdl-org/a-team for discussion?

@icculus
Copy link
Collaborator

icculus commented Dec 27, 2022

Should be SDL_FillSurfaceRect, I think.

Amen on finally getting rid of the UpperBlit naming, though.

@slouken
Copy link
Collaborator Author

slouken commented Dec 27, 2022

Should be SDL_FillSurfaceRect, I think.

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants