Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An event not working in a non-english version #33

Open
jmfergeau opened this issue May 29, 2017 · 9 comments
Open

An event not working in a non-english version #33

jmfergeau opened this issue May 29, 2017 · 9 comments

Comments

@jmfergeau
Copy link

jmfergeau commented May 29, 2017

(thanks to github for erasing my message while i was writing it btw! :D )

One particular event doesn't work on the french version of Cave Story: The event #1000 in Barr.tsc (when the player shoots Toroko at the beginning and speaks to her to talk to her about the pendant and trigger the fight with Balrog) Toroko doesn't reply when she is down. Quote doesn't display a ? at it but no dialog triggers, making the player stuck there forever.

I believe it comes from the NX Engine because:

  • I tried to directly start the exe of this french version, the event works fine
  • I tried the english version on the NX engine, the event works fine
  • I triple checked Barr.tsc, and except for the translated text, there's no typo or anything in the code.

For those who want to try, here's the french translation made ready for NX engine and having this strange glitch. This happens in the Linux and Windows versions of the engine.

(Is there a way to have a debug log of this core so maybe i can provide more info about this? Because RetroArch doesn't report any log at this point)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jmfergeau jmfergeau changed the title An event not working in An event not working in a non-english version May 29, 2017
@Harrypop
Copy link

Hello I've noticed this bug too, here is any way to fix ?

@isage
Copy link

isage commented Nov 15, 2017

It looks like French translation uses cs+ as a base.
cs+ adds some new opcodes to tsc (in this case <ACHxxxx, for achievements) so nxengine script parser fails.
Adding (noop) support for <ACH fixes this problem.

@Darknior
Copy link

@isage WOAW excellent you have a solution !!!!
From the time i stand for it, will you add it and make a pull request ?
Thanks

@jmfergeau
Copy link
Author

jmfergeau commented Nov 21, 2017

Can't believe nicalis did something that stupid -_- Indeed the french NX version used the files of cs+ to avoid rewriting all the text, since the text files are similar...
I'll get this fixed and try

EDIT: That was it. Removing the <ACHxxxx worked. Works like a charm now. I'm gonna update the package in a few.
Thanks for all, everyone. You can close this thread ^^

@Darknior
Copy link

The form on your site doesn't work, i can't write you.
Have you found a final solution for this french patch ?
I really want to try it. Thanks

@Darknior
Copy link

I have DL and test your new FRENCH version 1.2, and now all is working fine, thanks :)
http://cavestory.maxlefou.com/

@isage
Copy link

isage commented Dec 30, 2017

@maxlefou i was wondering if i can include your translation with nxengine-evo?
It'll be put up in source form on github, and i'll grant you dev rights to it, of course.

@jmfergeau
Copy link
Author

@isage of course, with pleasure! ^^

@Darknior
Copy link

Darknior commented Jan 1, 2018

Thanks @isage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants