Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORTANT] input_device_display_name_alt variables are not supported! #16995

Closed
davidhedlund opened this issue Sep 12, 2024 · 2 comments · Fixed by #17412
Closed

[IMPORTANT] input_device_display_name_alt variables are not supported! #16995

davidhedlund opened this issue Sep 12, 2024 · 2 comments · Fixed by #17412

Comments

@davidhedlund
Copy link
Contributor

davidhedlund commented Sep 12, 2024

Description

We need to implement support for alternative display names for input devices in our configuration files. This feature will allow users to specify multiple display names for different versions or variations of the same controller.

Steps to reproduce the issue

To highlight the issues arising from the lack of implementation for input_device_display_name_alt, it’s important to note that users often expect this feature to be available. Many will attempt to use input_device_display_name_alt under the assumption that it is already supported.

  1. Add this text to a sdl2, udev, or android autoconfig file:[1]
input_device = "sdl2"
input_device_display_name = "Controller version 2" # The latest versions of the controller is added first in our standard, because it is frequently overviewed
input_driver = "udev"
input_vendor_id = "1111"
input_product_id = "1111"
input_device_alt1 = "Controller spelled a bit different"
input_device_display_name_alt1 = "Controller version 1" # This is just to demonstrate what will happen for people with other versions of the controller
input_vendor_id_alt1 = "1356" # Replace the values with the VID for your controller
input_product_id_alt1 = "1476" # Replace the values with the PID for your controller
  1. Start RetroArch, and press any button on the controller.
  2. The controller becomes identified as "Controller version 2" instead of "Controller version 1".

Additional Notes

  • Ensure that similar configurations can be created for input_device_display_name_alt2 through input_device_display_name_alt8.
  • Consider how this will affect existing configurations and backward compatibility.

Expected Outcome

Users should be able to configure multiple display names for their input devices, enhancing flexibility and usability.

More

References

  1. Avoid to experiment with a linuxraw autoconfig file because it uses input_device to identify the controller instead of input_vendor_id and input_product_id

@zoltanvb

@davidhedlund davidhedlund changed the title Support alternative input_device_display_name variables Support input_device_display_name_alt variables Sep 12, 2024
@davidhedlund davidhedlund changed the title Support input_device_display_name_alt variables [IMPORTANT feature request] Support input_device_display_name_alt variables Sep 13, 2024
@davidhedlund davidhedlund changed the title [IMPORTANT feature request] Support input_device_display_name_alt variables Complete "[IMPORTANT feature request] Support input_device_display_name_alt variables" Sep 14, 2024
@davidhedlund davidhedlund changed the title Complete "[IMPORTANT feature request] Support input_device_display_name_alt variables" [IMPORTANT] input_device_display_name_alt variables is not supported! Jan 13, 2025
@davidhedlund
Copy link
Contributor Author

davidhedlund commented Jan 13, 2025

@zoltanvb The implementation of the input_device_display_name_alt variables is still needed. While these variables are not mandatory, they would significantly reduce confusion for users managing different versions of their controllers.

I rewrote the whole top post, please re-read it.

@davidhedlund
Copy link
Contributor Author

Thank you very much @zoltanvb !

@davidhedlund davidhedlund changed the title [IMPORTANT] input_device_display_name_alt variables is not supported! [IMPORTANT] input_device_display_name_alt variables are not supported! Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant