From bfa756cbfedf31ba0a3edb30ea7460ae28ad249e Mon Sep 17 00:00:00 2001 From: James Ray <16969914+jamesray1@users.noreply.github.com> Date: Mon, 5 Nov 2018 16:58:26 +1100 Subject: [PATCH 1/4] Fix grammar --- core/src/nodes/handled_node.rs | 2 +- muxers/mplex/src/lib.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/nodes/handled_node.rs b/core/src/nodes/handled_node.rs index c7ae87528f1..13e1f623ba7 100644 --- a/core/src/nodes/handled_node.rs +++ b/core/src/nodes/handled_node.rs @@ -54,7 +54,7 @@ pub trait NodeHandler { /// Injects an event coming from the outside into the handler. fn inject_event(&mut self, event: Self::InEvent); - /// Indicates that the node that it should shut down. After that, it is expected that `poll()` + /// Indicates to the node that it should shut down. After that, it is expected that `poll()` /// returns `Ready(None)` as soon as possible. /// /// This method allows an implementation to perform a graceful shutdown of the substreams, and diff --git a/muxers/mplex/src/lib.rs b/muxers/mplex/src/lib.rs index 14b2445162a..12ff37bc7e2 100644 --- a/muxers/mplex/src/lib.rs +++ b/muxers/mplex/src/lib.rs @@ -164,7 +164,7 @@ pub struct Multiplex { // Struct shared throughout the implementation. struct MultiplexInner { - // Errored that happend earlier. Should poison any attempt to use this `MultiplexError`. + // Error that happened earlier. Should poison any attempt to use this `MultiplexError`. error: Result<(), IoError>, // Underlying stream. inner: executor::Spawn>>, From 6d2e655ed45603282c3a97bc63f78981c635e57e Mon Sep 17 00:00:00 2001 From: James Ray <16969914+jamesray1@users.noreply.github.com> Date: Mon, 5 Nov 2018 17:35:06 +1100 Subject: [PATCH 2/4] Nothing we can *do* except ... --- transports/tcp/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/transports/tcp/src/lib.rs b/transports/tcp/src/lib.rs index e0b7ab42f3e..2d38a91235c 100644 --- a/transports/tcp/src/lib.rs +++ b/transports/tcp/src/lib.rs @@ -310,7 +310,7 @@ impl Stream for TcpListenStream { .expect("generating a multiaddr from a socket addr never fails"), Err(err) => { // If we can't get the address of the newly-opened socket, there's - // nothing we can except ignore this connection attempt. + // nothing we can do except ignore this connection attempt. error!("Ignored incoming because could't determine its \ address: {:?}", err); continue From edb4c926c636f07e05d655102d2fbd24d45f199d Mon Sep 17 00:00:00 2001 From: James Ray <16969914+jamesray1@users.noreply.github.com> Date: Tue, 6 Nov 2018 18:02:01 +1100 Subject: [PATCH 3/4] Implementer --- core/src/nodes/node.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/nodes/node.rs b/core/src/nodes/node.rs index e072e57d068..dfff0a575b9 100644 --- a/core/src/nodes/node.rs +++ b/core/src/nodes/node.rs @@ -25,7 +25,7 @@ use std::fmt; use std::io::Error as IoError; use std::sync::Arc; -// Implementor notes +// Implementer notes // ================= // // In order to minimize the risk of bugs in higher-level code, we want to avoid as much as From ed833449bc178fcd46188b9dc20530c314f8df83 Mon Sep 17 00:00:00 2001 From: James Ray <16969914+jamesray1@users.noreply.github.com> Date: Wed, 7 Nov 2018 09:53:54 +1100 Subject: [PATCH 4/4] Implementation --- core/src/nodes/node.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/nodes/node.rs b/core/src/nodes/node.rs index dfff0a575b9..daa717b1e1d 100644 --- a/core/src/nodes/node.rs +++ b/core/src/nodes/node.rs @@ -25,7 +25,7 @@ use std::fmt; use std::io::Error as IoError; use std::sync::Arc; -// Implementer notes +// Implementation notes // ================= // // In order to minimize the risk of bugs in higher-level code, we want to avoid as much as