Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript build error #1088

Closed
twoeths opened this issue Dec 27, 2021 · 5 comments
Closed

Typescript build error #1088

twoeths opened this issue Dec 27, 2021 · 5 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@twoeths
Copy link
Contributor

twoeths commented Dec 27, 2021

This is a continuation of #1073

  • Version:
    0.35.6

  • Platform:
    Mac OS X

  • Subsystem:

Severity:

High - Lodestar could not compile

Description:

Compilation error when using v0.35.6 with lodestar:

@chainsafe/lodestar: ../../node_modules/libp2p/node_modules/native-abort-controller/dist/src/index.d.ts:1:10 - error TS2661: Cannot export 'AbortSignal'. Only local declarations can be exported from a module.
@chainsafe/lodestar: 1 export { AbortSignal, AbortController };
@chainsafe/lodestar:            ~~~~~~~~~~~
@chainsafe/lodestar: ../../node_modules/libp2p/node_modules/native-abort-controller/dist/src/index.d.ts:1:23 - error TS2661: Cannot export 'AbortController'. Only local declarations can be exported from a module.
@chainsafe/lodestar: 1 export { AbortSignal, AbortController };

Steps to reproduce the error:

Build 0.35.6 with lodestar

@twoeths twoeths added the need/triage Needs initial labeling and prioritization label Dec 27, 2021
@twoeths
Copy link
Contributor Author

twoeths commented Dec 27, 2021

PR in progress achingbrain/native-abort-controller#5

@twoeths
Copy link
Contributor Author

twoeths commented Jan 3, 2022

there's a work in progress to remove abort-controller dependencies ipfs/js-ipfs#4001, need to confirm again after that's done

@wemeetagain
Copy link
Member

may be worth re-checking now

@twoeths
Copy link
Contributor Author

twoeths commented Jan 24, 2022

@wemeetagain latest master works with version 3.0.0 of timeout-abort-controller, I'm working on fixing types in lodestar.

@achingbrain waiting for a new release of js-libp2p to close this issue

@twoeths
Copy link
Contributor Author

twoeths commented Jan 24, 2022

issue is fixed on master, closing

@twoeths twoeths closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants