Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this module support peer routing? #7

Closed
guysv opened this issue Feb 17, 2019 · 2 comments
Closed

Does this module support peer routing? #7

guysv opened this issue Feb 17, 2019 · 2 comments

Comments

@guysv
Copy link

guysv commented Feb 17, 2019

interface-peer-routing states that this module implements the peer routing API, but I see no tests to confirm this. Also, I couldn't find a findPeers method.

Who got it right?

@jacobheun
Copy link
Contributor

The interface needs to be updated, it also doesn't include any exported tests yet, which also needs to be fixed. The state of this module is currently correct, you can see an example of it and content routing at https://github.com/libp2p/js-libp2p/tree/v0.24.4/examples/delegated-routing. The DHT also matches this implementation.

I created an issue so this gets tracked libp2p/interface-peer-routing#18, thanks for bringing this up.

@achingbrain
Copy link
Member

This has been fixed, https://www.npmjs.com/package/@libp2p/interface-peer-routing no longer references this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants