Client.connect: Handle unspecified error in response #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
bugfix/handle-unspecified-connect-failure
branch
4 times, most recently
from
7a34a01 to
ace8830
Compare
|
Thanks for the PR @aknuds1 . Can you please rebase this with the new changes in master before I review it? |
aknuds1
force-pushed
the
bugfix/handle-unspecified-connect-failure
branch
2 times, most recently
from
3cad465 to
73c25d0
Compare
aknuds1
force-pushed
the
bugfix/handle-unspecified-connect-failure
branch
from
73c25d0 to
7be4616
Compare
|
@vasco-santos Done! |
vasco-santos
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when testing in libp2p/interop, that this library would sometimes fail in
Client.connectdue to an undefinedErrorResponsein the response. With this PR I try to handle this case gracefully. I observed that the error could have anerrorproperty instead, so I added tests both for whenerroris defined and when neither that notErrorResponseis present.I also added chai-as-promised as a dev dependency, in order to test async errors more cleanly (without boilerplate).