Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address observations should be dropped when overloaded #584

Closed
Stebalien opened this issue Apr 9, 2019 · 2 comments
Closed

Address observations should be dropped when overloaded #584

Stebalien opened this issue Apr 9, 2019 · 2 comments
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

We should consider rewriting the address observation system to:

  1. Use a single observation worker.
  2. Drop observations when we get overloaded (i.e., write to a channel with a select and a default case).

(cc @vyzo)

@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label Apr 9, 2019
@vyzo
Copy link
Contributor

vyzo commented Apr 9, 2019

Given the discovery of 1.2M stuck goroutines in a relay, this should be a priority.
Perhaps we should consider having an option to disable it altogether for cases of public nodes with known ips.

@ghost ghost assigned vyzo Apr 9, 2019
@ghost ghost added the status/in-progress In progress label Apr 9, 2019
@Stebalien
Copy link
Member Author

Yeah, we can probably have some heuristic like: "if we've received N inbound connections in the last M minutes, ignore any observed addresses". However, I'm not sure how that'll interact with autonat and changing networks.

@vyzo vyzo closed this as completed in #585 Apr 9, 2019
@ghost ghost removed the status/in-progress In progress label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants