metrics: observed address mgr

[p-shahi]

Number of activated addresses: IP Version + Transport
Nat Type: (Unknown, Symmetric, Cone)

[sukunrt]

I'm tracking these from holepunch metrics. We are only interested in activated addresses. Tracking at observedAddressManager leads to a lot of book keeping like wasActivatedBefore isActivatedNow everywhere.

At the moment we are only interested in public address counts by ipversion and transport for holepunches, so my approach feels okay.

[sukunrt]

I'm tracking these from holepunch metrics. We are only interested in activated addresses. Tracking at observedAddressManager leads to a lot of book keeping like wasActivatedBefore isActivatedNow everywhere.

I have changed this strategy. It is better to track these from observed address manager. I don't remember what my reasoning was here, but I think there's a way to do this that's hopefully not too complicated.