Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: Add NoAlloc test to swarm metrics #2060

Closed
MarcoPolo opened this issue Feb 6, 2023 · 1 comment · Fixed by #2108
Closed

swarm: Add NoAlloc test to swarm metrics #2060

MarcoPolo opened this issue Feb 6, 2023 · 1 comment · Fixed by #2108
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue

Comments

@MarcoPolo
Copy link
Collaborator

We should do something similar to https://github.com/libp2p/go-libp2p/pull/2044/files#diff-a7e11ff3f575edcb9fbc9681cc048d71fb1f1eb652aabbb3fcea13104335169b to have a test that ensures swarm metrics don't allocate.
@MarcoPolo
Copy link
Collaborator Author

And the event bus metrics as well.

@marten-seemann marten-seemann added help wanted Seeking public contribution on this issue exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Feb 7, 2023
@marten-seemann marten-seemann changed the title Add NoAlloc test to swarm metrics swarm: Add NoAlloc test to swarm metrics Feb 7, 2023
@sukunrt sukunrt mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: add no alloc metrics for eventbus, swarm, identify sukunrt/go-libp2p
2 participants
@MarcoPolo @marten-seemann