Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: consider removing the LocalPrivateKey method from secure connections #1695

Closed
Stebalien opened this issue Mar 8, 2018 · 1 comment · Fixed by #2144
Closed

core: consider removing the LocalPrivateKey method from secure connections #1695

Stebalien opened this issue Mar 8, 2018 · 1 comment · Fixed by #2144

Comments

@Stebalien
Copy link
Member

It's really not necessary and generally not a good idea to expose private keys like this.

@whyrusleeping
Copy link
Contributor

To clarify this scary sounding issue, @Stebalien is talking about the LocalPrivateKey method on the secureConn type that returns the private key we are using for the encrypted channel. Its not (as one might assume by reading the title) leaking private key data over the network in any way.

@Stebalien Stebalien changed the title Consider not exposing private keys on secure connections Consider removing the LocalPrivateKey method from secure connections Mar 8, 2018
@Stebalien Stebalien transferred this issue from libp2p/go-libp2p-net Dec 6, 2019
@marten-seemann marten-seemann changed the title Consider removing the LocalPrivateKey method from secure connections core: consider removing the LocalPrivateKey method from secure connections Aug 19, 2022
@marten-seemann marten-seemann transferred this issue from libp2p/go-libp2p-core Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants