Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

flaky unit test #203

Closed
marten-seemann opened this issue Apr 5, 2021 · 2 comments · Fixed by #204
Closed

flaky unit test #203

marten-seemann opened this issue Apr 5, 2021 · 2 comments · Fixed by #204
Assignees
@marten-seemann
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up topic/windows Windows specific

Comments

@marten-seemann
Copy link
Collaborator 

Connection 
  dials to two servers at the same time
  D:/a/go-libp2p-quic-transport/go-libp2p-quic-transport/conn_test.go:230
 using an ECDSA key: QmUoxHQ1XEoxx7djJHsj4atge6khZzzVUr7wsTnGkXeB2w
 using an ECDSA key: QmTtpKFpp8GMMaLCZsAbos8Ebj6xEZZEyexwXkv3ncCvQ2
 using an ECDSA key: QmYDEmCANdqfYQb2hyb6QCZtezrPCFt7nhtApZgzdgr9fP

+ Failure [5.073 seconds]
Connection
D:/a/go-libp2p-quic-transport/go-libp2p-quic-transport/conn_test.go:27
  dials to two servers at the same time [It]
  D:/a/go-libp2p-quic-transport/go-libp2p-quic-transport/conn_test.go:230

  Timed out after 5.000s.
  Expected
      <chan struct {} | len:0, cap:2>: 0x124eb3c0
  to receive something.

  D:/a/go-libp2p-quic-transport/go-libp2p-quic-transport/conn_test.go:287

  Full Stack Trace
  github.com/libp2p/go-libp2p-quic-transport.glob..func2.10()
  	D:/a/go-libp2p-quic-transport/go-libp2p-quic-transport/conn_test.go:287 +0x984
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0x1260c5c0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:113 +0x7a
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).run(0x1260c5c0, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:64 +0xb3
  github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run(0x12404b20, 0x12bf420, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/it_node.go:26 +0x44
  github.com/onsi/ginkgo/internal/spec.(*Spec).runSample(0x12601880, 0x0, 0x12bf420, 0x1254ad00)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:215 +0x509
  github.com/onsi/ginkgo/internal/spec.(*Spec).Run(0x12601880, 0x12bf420, 0x1254ad00)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:138 +0xd3
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec(0x1268e000, 0x12601880, 0x10)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:200 +0xd1
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs(0x1268e000, 0x1)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:170 +0xf7
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run(0x1268e000, 0x124253e0)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:66 +0xf1
  github.com/onsi/ginkgo/internal/suite.(*Suite).Run(0x124b1bc0, 0x123b00b0, 0x124388c0, 0x10d7661, 0x1b, 0x12406280, 0x1, 0x1, 0x12c7ac0, 0x1254ad00, ...)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/internal/suite/suite.go:79 +0x3e6
  github.com/onsi/ginkgo.RunSpecsWithCustomReporters(0x12bfc00, 0x124388c0, 0x10d7661, 0x1b, 0x1244bf84, 0x1, 0x1, 0x9abddc)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:219 +0x181
  github.com/onsi/ginkgo.RunSpecs(0x12bfc00, 0x124388c0, 0x10d7661, 0x1b, 0x1652960)
  	C:/Users/runneradmin/go/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:200 +0x128
  github.com/libp2p/go-libp2p-quic-transport.TestLibp2pQuicTransport(0x124388c0)
  	D:/a/go-libp2p-quic-transport/go-libp2p-quic-transport/libp2pquic_suite_test.go:20 +0x7a
  testing.tRunner(0x124388c0, 0x121c9d4)
  	C:/hostedtoolcache/windows/go/1.15.10/x64/src/testing/testing.go:1123 +0xc4
  created by testing.(*T).Run
  	C:/hostedtoolcache/windows/go/1.15.10/x64/src/testing/testing.go:1168 +0x211
@marten-seemann marten-seemann added exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up effort/hours Estimated to take one or several hours labels Apr 5, 2021
@marten-seemann marten-seemann self-assigned this Apr 5, 2021
@marten-seemann marten-seemann added the topic/windows Windows specific label Apr 5, 2021
@marten-seemann
Copy link
Collaborator Author

Why is everything on Windows such a pain...

Failed to compile go-libp2p-quic-transport:

# runtime/cgo
cgo: exec gcc: exec: "gcc": executable file not found in %PATH%

@marten-seemann
Copy link
Collaborator Author

Now this is annoying. Because we're using a connection on localhost, the RTT is close to 0, which means that any scheduling delay will be picked up immediately by the loss recovery algorithm. Easy solution: just increase the timeout.

@marten-seemann marten-seemann mentioned this issue Apr 6, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marten-seemann marten-seemann

Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up topic/windows Windows specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase test timeout to reduce flakiness of test on Windows libp2p/go-libp2p-quic-transport
1 participant
@marten-seemann