Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish fails even after timecache expiry #467

Closed
kostko opened this issue Dec 30, 2021 · 1 comment
Closed

Republish fails even after timecache expiry #467

kostko opened this issue Dec 30, 2021 · 1 comment

Comments

@kostko
Copy link

kostko commented Dec 30, 2021

It seems that currently republishing a duplicate message fails even after the timecache entry should have expired if that is the only message being (re)published. This is due to the sweep method only being called after Add which is only ever called when a new message is added in markSeen.

If we have a simple example where there is only a single message being republished, the sweep will never happen and thus the old message ID will be left stale in the timecache, preventing publication.

The timecache should either be swept periodically or before Has (see related issue whyrusleeping/timecache#2).

@kostko
Copy link
Author

kostko commented May 25, 2023

This has been fixed in the new in-tree timecache implementation by using a background goroutine that periodically sweeps.

@kostko kostko closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant