Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic methods should select on PubSub's context #226

Closed
Stebalien opened this issue Nov 1, 2019 · 3 comments
Closed

Topic methods should select on PubSub's context #226

Stebalien opened this issue Nov 1, 2019 · 3 comments
Assignees
@aschmahmann

Comments

@Stebalien
Copy link
Member

Currently, they'll block when called if pubsub has been closed.
@Stebalien Stebalien mentioned this issue Nov 1, 2019
Merged
@aschmahmann
Copy link
Contributor

@Stebalien This seems to be true for all of the PubSub methods as well. Should we fix them there as well?

@vyzo
Copy link
Collaborator

vyzo commented Nov 3, 2019

Yes, let's fix them!

@aschmahmann
Copy link
Contributor

closed by #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aschmahmann aschmahmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vyzo @Stebalien @aschmahmann