Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

remove peer ID validity checks #182

Closed
marten-seemann opened this issue Nov 28, 2021 · 0 comments · Fixed by #194
Closed

remove peer ID validity checks #182

marten-seemann opened this issue Nov 28, 2021 · 0 comments · Fixed by #194
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@marten-seemann
Copy link
Contributor

They were needed since our old insecure handshake protocol didn't determine the peer's ID. plaintextv2 does exchange peer IDs and keys, so this problem should not exist any more.

We should check that all plaintext v1 code paths are removed before making this change.
@marten-seemann marten-seemann added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours labels Nov 28, 2021
@marten-seemann marten-seemann mentioned this issue Dec 19, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove all calls to peer.ID.Validate libp2p/go-libp2p-peerstore
1 participant
@marten-seemann