Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake options should be prefixed with OCCA to avoid name conflicts when used in bigger projects #612

Closed
stgeke opened this issue Aug 9, 2022 · 3 comments · Fixed by #733
Closed

CMake options should be prefixed with OCCA to avoid name conflicts when used in bigger projects #612

stgeke opened this issue Aug 9, 2022 · 3 comments · Fixed by #733
Labels
beginner A good place to wade into OCCA development build priority Issues that are high priority for downstream projects
Milestone
v2.0

Comments

@stgeke
Copy link
Contributor

stgeke commented Aug 9, 2022

No description provided.

@kris-rowe
Copy link
Member

Agreed. Good call.

@kris-rowe kris-rowe added beginner A good place to wade into OCCA development priority Issues that are high priority for downstream projects labels Dec 20, 2022
@kris-rowe kris-rowe added this to the v1.7 milestone Sep 14, 2023
@lookingup42
Copy link

Hello, I'm interested in helping with this! Wanted try my hand and learn as I go! Is this up for grabs? I saw that the last activity was last month

@kris-rowe
Copy link
Member

Hello, I'm interested in helping with this! Wanted try my hand and learn as I go! Is this up for grabs? I saw that the last activity was last month

We are always happy to welcome new contributors. Feel free to tackle this issue.

Whenever you create a pull-request for, please have it target the development branch.
If you would like some early feedback on your PR before it is finished, you can open it early and mark it as a draft.

@kris-rowe kris-rowe mentioned this issue Dec 18, 2023
Merged
@kris-rowe kris-rowe linked a pull request Dec 18, 2023 that will close this issue
Prefix CMake build options with OCCA #733
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner A good place to wade into OCCA development build priority Issues that are high priority for downstream projects
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Prefix CMake build options with OCCA argonne-lcf/occa
3 participants
@stgeke @kris-rowe @lookingup42