Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs branch has lots of docstring conflicts with what sphinx expects #4

Closed
bernstei opened this issue Nov 22, 2021 · 4 comments
Closed

Comments

@bernstei
Copy link
Contributor

Lots of docstrings are not formatted according to what sphinx expects. I will start to fix those, at least the ones that give warnings and I can figure out, and push to the docs branch.

@bernstei
Copy link
Contributor Author

@gelzinyte Are you happy with the changes in my latest pushes (up to 110ceb2)? I suspect there are lots of other ugly things in the docstrings, e.g. places where there are two separate sentences broken up by a single line break without punctuation, which sphinx just runs together. But I think I got all the things bad enough to generate warnings.

@gelzinyte
Copy link
Contributor

gelzinyte commented Nov 22, 2021

Yup, those changes look good. I'm cleaning up and adding missing docstrings (e.g. they're not even picked up sometimes), I think these should be sorted out too, while I/we are at it.

@bernstei
Copy link
Contributor Author

bernstei commented Nov 22, 2021

Should we close this issue, or do you want to keep it open to remind us about the other problems?

@gelzinyte
Copy link
Contributor

I think a documentation to-do reminder would be good, but I'll open a less specific dedicated issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants