Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to ignore case in key names #66

Open
jameskermode opened this issue Aug 29, 2019 · 6 comments
Open

add option to ignore case in key names #66

jameskermode opened this issue Aug 29, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@jameskermode
Copy link
Member

I uploaded a file containing some properties named DFT_force and others named dft_force. I know I can rename them with abcd rename-key, but since in ASE and QUIP case is ignored for property names it would be good to have an option to do this in abcd. Maybe this should even be the default?

@fekad
Copy link
Contributor

fekad commented Oct 1, 2019

This can only work if never two store keys which only differ in their case. Would that be ok?

@jameskermode
Copy link
Member Author

I think this would be ok, yes. Maybe start with a non-default option to ignore case and see how it goes?

@fekad
Copy link
Contributor

fekad commented Oct 16, 2019

It woud be nice if we stored properties in case sensitive mode, but optionally allowed the user to search case insensitively. for this to work, I have to find out if Mongo supports case insensitive searches. if it doesn't then we can decide to either not have this option or to actually store everything in lower case.

@fekad
Copy link
Contributor

fekad commented Oct 16, 2019

As far as I know, MongoDB doesn't have any option to ignore the cases for the keys:

There is a way to create case insensitive indices but not for the

So the possible options:

  1. store everything in lower case
  2. store everything in a case sensitive way but having an optional flag for upload to convert every key to lower case (of course the rename-key is still available if needed)
  3. store everything in a case sensitive way but having a nice tutorial for the rename-key command

@fekad
Copy link
Contributor

fekad commented Nov 1, 2019

Any decision about this?

@fekad
Copy link
Contributor

fekad commented Nov 15, 2019

Decision: default to the lower casing keywords with a command-line option to not do it. + pre-check @ upload

@gabor1 gabor1 added the enhancement New feature or request label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants