Skip to content

Commit

Permalink
got rubocop setup. reconfigured the config. started scaffolding the r…
Browse files Browse the repository at this point in the history
…outing
  • Loading branch information
lgflorentino committed Sep 22, 2024
1 parent d11fb99 commit 19383e2
Show file tree
Hide file tree
Showing 29 changed files with 451 additions and 189 deletions.
282 changes: 282 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,282 @@
# This is a config synced from dry-rb/template-gem repo

require:
- rubocop-on-rbs

AllCops:
TargetRubyVersion: 3.0
NewCops: disable
SuggestExtensions: false
Exclude:
- "**/vendor/**/*" # For GitHub Actions, see rubocop/rubocop#9832
- benchmarks/*.rb
- spec/support/coverage.rb
- spec/support/warnings.rb
- spec/support/rspec_options.rb
- Gemfile.devtools
- "*.gemspec"

Layout/SpaceAroundMethodCallOperator:
Enabled: false

Layout/SpaceInLambdaLiteral:
Enabled: false

Layout/MultilineMethodCallIndentation:
Enabled: true
EnforcedStyle: indented

Layout/FirstArrayElementIndentation:
EnforcedStyle: consistent

Layout/SpaceInsideHashLiteralBraces:
Enabled: true
EnforcedStyle: no_space
EnforcedStyleForEmptyBraces: no_space

Layout/LineLength:
Max: 100
Exclude:
- "spec/**/*.rb"

Lint/AmbiguousBlockAssociation:
Enabled: true
# because 'expect { foo }.to change { bar }' is fine
Exclude:
- "spec/**/*.rb"

Lint/BooleanSymbol:
Enabled: false

Lint/ConstantDefinitionInBlock:
Exclude:
- "spec/**/*.rb"

Lint/RaiseException:
Enabled: false

Lint/StructNewOverride:
Enabled: false

Lint/SuppressedException:
Exclude:
- "spec/spec_helper.rb"

Lint/LiteralAsCondition:
Exclude:
- "spec/**/*.rb"

Naming/PredicateName:
Enabled: false

Naming/FileName:
Exclude:
- "lib/*-*.rb"

Naming/MethodName:
Enabled: false

Naming/MethodParameterName:
Enabled: false

Naming/MemoizedInstanceVariableName:
Enabled: false

Metrics/MethodLength:
Enabled: false

Metrics/ClassLength:
Enabled: false

Metrics/BlockLength:
Enabled: false

Metrics/AbcSize:
Max: 25

Metrics/CyclomaticComplexity:
Enabled: true
Max: 12

Style/FrozenStringLiteralComment:
Exclude:
- "config/am.conf.rb"

Style/ExponentialNotation:
Enabled: false

Style/HashEachMethods:
Enabled: false

Style/HashTransformKeys:
Enabled: false

Style/HashTransformValues:
Enabled: false

Style/AccessModifierDeclarations:
Enabled: false

Style/Alias:
Enabled: true
EnforcedStyle: prefer_alias_method

Style/AsciiComments:
Enabled: false

Style/BlockDelimiters:
Enabled: false

Style/ClassAndModuleChildren:
Exclude:
- "spec/**/*.rb"

Style/ConditionalAssignment:
Enabled: false

Style/DateTime:
Enabled: false

Style/Documentation:
Enabled: false

Style/EachWithObject:
Enabled: false

Style/FormatString:
Enabled: false

Style/FormatStringToken:
Enabled: false

Style/GuardClause:
Enabled: false

Style/IfUnlessModifier:
Enabled: false

Style/Lambda:
Enabled: false

Style/LambdaCall:
Enabled: false

Style/ParallelAssignment:
Enabled: false

Style/RaiseArgs:
Enabled: false

Style/StabbyLambdaParentheses:
Enabled: false

Style/StringLiterals:
Enabled: true
EnforcedStyle: double_quotes
ConsistentQuotesInMultiline: false

Style/StringLiteralsInInterpolation:
Enabled: true
EnforcedStyle: double_quotes

Style/SymbolArray:
Exclude:
- "spec/**/*.rb"

Style/TrailingUnderscoreVariable:
Enabled: false

Style/MultipleComparison:
Enabled: false

Style/Next:
Enabled: false

Style/AccessorGrouping:
Enabled: false

Style/EmptyLiteral:
Enabled: false

Style/Semicolon:
Exclude:
- "spec/**/*.rb"

Style/HashAsLastArrayItem:
Exclude:
- "spec/**/*.rb"

Style/CaseEquality:
Exclude:
- "lib/dry/monads/**/*.rb"
- "lib/dry/struct/**/*.rb"
- "lib/dry/types/**/*.rb"
- "spec/**/*.rb"

Style/ExplicitBlockArgument:
Exclude:
- "lib/dry/types/**/*.rb"

Style/CombinableLoops:
Enabled: false

Style/EmptyElse:
Enabled: false

Style/DoubleNegation:
Enabled: false

Style/MultilineBlockChain:
Enabled: false

Style/NumberedParametersLimit:
Max: 2

Lint/UnusedBlockArgument:
Exclude:
- "spec/**/*.rb"

Lint/UselessAssignment:
Exclude:
- "config/am.conf.rb"

Lint/Debugger:
Exclude:
- "bin/console"

Lint/BinaryOperatorWithIdenticalOperands:
Exclude:
- "spec/**/*.rb"

Metrics/ParameterLists:
Exclude:
- "spec/**/*.rb"

Lint/EmptyBlock:
Exclude:
- "spec/**/*.rb"

Lint/EmptyFile:
Exclude:
- "spec/**/*.rb"

Lint/UselessMethodDefinition:
Exclude:
- "spec/**/*.rb"

Lint/SelfAssignment:
Enabled: false

Lint/EmptyClass:
Enabled: false

Naming/ConstantName:
Exclude:
- "spec/**/*.rb"

Naming/VariableNumber:
Exclude:
- "spec/**/*.rb"

Naming/BinaryOperatorParameterName:
Enabled: false
3 changes: 0 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,3 @@ source "https://rubygems.org"
gemspec

gem "rake", "~> 13.0"



7 changes: 3 additions & 4 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@
require "bundler/gem_tasks"
require "rspec/core/rake_task"

RSpec::Core::RakeTask.new(:spec)

require "rubocop/rake_task"

RSpec::Core::RakeTask.new(:spec)
RuboCop::RakeTask.new

task default: %i[spec rubocop]
task default: %i[rubocop spec]

task :docker_tests do
task :docker_tests do
ruby "spec/docker/run_docker_tests.rb"
end
2 changes: 1 addition & 1 deletion activity_monitor.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ Gem::Specification.new do |spec|
spec.add_dependency "hanami-router", "~> 2.1.0"
spec.add_dependency "zeitwerk", "~>2.6.13"
spec.add_dependency "rack", "~> 2.0"
spec.add_dependency "rainbow", "~> 3.1.1"

spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "rubocop", "~> 1.21"
spec.add_development_dependency "rubocop-on-rbs", "~> 1.0.0"
spec.add_development_dependency "puma", "~> 6.0"
# For more information and examples about making a new gem, check out our
# guide at: https://bundler.io/guides/creating_gem.html
Expand Down
2 changes: 0 additions & 2 deletions bin/console
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,3 @@ require "activity_monitor"

require "irb"
IRB.start(__FILE__)


2 changes: 2 additions & 0 deletions config.ru
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "activity_monitor/standalone"

run ActivityMonitor.run
16 changes: 16 additions & 0 deletions config/am.conf.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# frozen_string_literal: true

module ActivityMonitor
class Config
AM_CONF = {
root_slug: "/api/am",
enabled_services: %i[
github
gitlab
bitbucket
sourcehut
codeberg
]
}.freeze
end
end
1 change: 0 additions & 1 deletion exe/am
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@
require_relative "../lib/activity_monitor/cli/commands"

ActivityMonitor::CLI::Commands

14 changes: 5 additions & 9 deletions lib/activity_monitor.rb
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
#frozen_string_literal: true
# frozen_string_literal: true

require "hanami" if Gem.loaded_specs.has_key? "hanami"
require "hanami" if Gem.loaded_specs.key? "hanami"
require "zeitwerk"
loader = Zeitwerk::Loader.for_gem
loader.inflector.inflect("cli" => "CLI")
loader.setup

module ActivityMonitor

def self.setup

unless instance_variable_defined?(:@am)
@am = ActivityMonitor::App::new
@am = ActivityMonitor::App.new
end

if (defined? Hanami) && Hanami::app?
if (defined? Hanami) && Hanami.app?
@am.set_config "is_hanami_app=", true
end

Expand All @@ -23,8 +21,6 @@ def self.setup
end

def self.run
self.setup
setup
end

end

Loading

0 comments on commit 19383e2

Please sign in to comment.