Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#NaN on border-color when parsing rgb command line #812

Closed
DataHerder opened this issue May 22, 2012 · 9 comments
Closed

#NaN on border-color when parsing rgb command line #812

DataHerder opened this issue May 22, 2012 · 9 comments

Comments

@DataHerder
Copy link

FYI:

Say I use lessc on a file that simply has this class:

.random {
  border-color: transparent transparent transparent rgb(230,230,230);
}

It will output:

.random {
  border-color: #NaNbbaaNaN00NaN00NaN00NaN00NaN #NaNbbaaNaN00NaN00NaN00NaN00NaN #NaNbbaaNaN00NaN00NaN00NaN00NaN #e6e6e6;
}

However this will not happen if I run it on this:

.random {
  border-color: transparent transparent transparent #e6e6e6;
}

I have tested this on "color" as well so I think this is a global issue.

@DataHerder
Copy link
Author

It also does this on background: transparent url('');

@phiamo
Copy link

phiamo commented May 27, 2012

can confirm, merging #800 breaks also compiling of twitters bootstrap2 ...
unusable atm :(

@lukeapage
Copy link
Member

Amazing that of all the great pull requests to include a dud one was included and now.. Silence..

@DataHerder
Copy link
Author

I really want to see Less.js stay around. I immensely enjoy this contribution.

@taeram
Copy link

taeram commented May 30, 2012

I'd also love to see this one fixed right away. We're updating less to the latest on a regular basis, and we're having to force a checkout of an earlier version to prevent this issue.

👍 to merge pull request #806, reverting changes in pull request #800

@dfjones
Copy link

dfjones commented Jun 30, 2012

+1 to revert #800

This change is really bad and has been shown to break a lot of existing code.

@sturobson
Copy link

I've just tried this w/ latest LESS.js app and it outputs as expected with no errors. Can you confirm how you're compiling?

@dfjones
Copy link

dfjones commented Jun 30, 2012

Don't use the app. Clone this repo, and use /bin/lessc

@lukeapage
Copy link
Member

this was reverted, so should be fine now and some of us are working on sorting things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants