Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled code minification for release builds #410

Open
leonlatsch opened this issue Feb 6, 2025 · 0 comments
Open

Enabled code minification for release builds #410

leonlatsch opened this issue Feb 6, 2025 · 0 comments
Labels
technical Refactoring or other technical issues

Comments

@leonlatsch
Copy link
Owner

leonlatsch commented Feb 6, 2025

After #402 raised raw APK size (not download size). I noticed that we currently don't have minify enabled.

    buildTypes {
        getByName("release") {
            isMinifyEnabled = false
            proguardFiles(
                getDefaultProguardFile("proguard-android-optimize.txt"),
                "proguard-rules.pro"
            )
        }
    }

When enabling it, some crashes happen. Fix those and enable minify.

One of the crashes is related to OssLicenseView. Its a third party library maintained by me, so I will need to fix it: https://github.com/leonlatsch/OssLicenseView

@leonlatsch leonlatsch added the technical Refactoring or other technical issues label Feb 6, 2025
@leonlatsch leonlatsch changed the title Use minify Enabled code minification for release builds Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Refactoring or other technical issues
Projects
None yet
Development

No branches or pull requests

1 participant